Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromLinks add missing param to loadSingle call #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

martypdx
Copy link
Contributor

@martypdx martypdx commented Aug 5, 2014

Attempt to address #7. Not really sure if this is right thing to do, but loading fromLinks doesn't work otherwise (I'm I the only one loading from links? What are all the kool kids using, AMD?)

Also passed along cache parameter in other instance @MartinKolarik mentioned.

Not as familiar with this code, so would appreciate someone chiming in.

@XavierBoubert
Copy link

👍 Is that possible to Merge this PR from 7 months ago?

@Rich-Harris
Copy link
Member

Hah, whoops! Am just merging in some other changes which may cause conflicts with this, so I'll do it manually afterwards. Thanks for bumping it

Rich-Harris added a commit that referenced this pull request Mar 18, 2015
@martypdx
Copy link
Contributor Author

can we close this one then @Rich-Harris?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants