Replace astropy-init w/spectral-cube version #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is related to pytest openfiles. Do we need https://github.com/astropy/pytest-openfiles as a dependency? |
|
@e-koch or @astrofrog any chance you can help out with this? |
|
Can we just drop the open files check for tests? I think that's what we've done elsewhere There's another failure in hear from a change in skimage, too, that I can check out |
|
Yeah, totally good to drop the openfiles check |
|
We still have a bunch of failures that I think are unrelated to this PR but do need fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the current failure on import w/astropy 6