Popover: Feature: Allow an additional prop to be passed that changes trigger behavior from toggle to always open #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidrautert
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a boolean prop that allows the user to change the behavior of the Popover's toggling open. Defaulting to true, if set to false then the Popover Trigger will always pass true to setOpen
Context
When using a Popover in conjunction with a form field, using the field as the trigger would previously result in the Popover toggling, even when the input was focused and the user clicked on it again. The user may want to change their cursor position to edit some text, for instance.
It may be desirable to allow the Popover to remain open so long as the input is being interacted with. It is possible to manage the open state and work around this, but I found that it introduces some additional complexity whereas this is a simple boolean prop.