Feature: Versioned package substates #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for a3f2a35Click to view benchmark
|
talekhinezh
reviewed
Aug 21, 2023
| OriginalCode, | ||
| InstrumentedCode, | ||
| } | ||
| macro_rules! blueprint_partition_offset { |
There was a problem hiding this comment.
Can we remove these mappings as discussed?
There was a problem hiding this comment.
Not easily - these are currently used by the TypedSubstate mapping, which we need for reverse-mapping the substate stream to typed substates.
| @@ -0,0 +1,157 @@ | |||
| use crate::internal_prelude::*; | |||
|
|
|||
| pub trait FeatureSetResolver: Debug { | |||
There was a problem hiding this comment.
Can we rename to something like HasFeatures, Resolver seems to imply a process which takes input.
|
|
||
| /// For feature checks against a non-inner object | ||
| #[derive(Debug)] | ||
| pub enum FeatureChecks<TOwn: FeatureSetResolver> { |
There was a problem hiding this comment.
As discussed can we remove FeatureChecks?
|
|
||
| /// Generates types and typed-interfaces for native blueprints, their | ||
| /// state models, features, partitions, and their interaction with | ||
| /// the substate store. |
There was a problem hiding this comment.
Update comment to remove "partitions and their interactions with the substate store"
| /// For each collection key, the following types will be created: | ||
| /// * `<BlueprintIdent><CollectionIdent>KeyPayload` - a new type for the key payload (eg includes the u16 for a sorted index key) | ||
| /// | ||
| /// The content of each of the above can take a number of forms. |
| blueprint_version_definitions: KeyValue { | ||
| entry_ident: BlueprintVersionDefinition, | ||
| key_type: { | ||
| kind: Static, |
There was a problem hiding this comment.
Does key_type have another kind besides Static?
talekhinezh
approved these changes
Aug 21, 2023
dhedey
force-pushed
the
feature/core-substate-model-versioning
branch
from
a10d0ff
to
4518cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A slightly stripped back #1318 which avoids generating the
_StateInitand the_Partitionmodels.I've generally tried to avoid changing things that don't need changing, but I don't think there's anything particularly controversial left?
This implements for packages, and in a separate PR, I'll implement for other native blueprints.
Update Recommendations
For Internal Integrators
I'll merge this into the node. This shouldn't have any impact outside of Scrypto and Node.