-
-
Notifications
You must be signed in to change notification settings - Fork 528
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add nodes validation to the admin site (#1818)
- Loading branch information
Showing
3 changed files
with
150 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,124 @@ | ||
from ..site import Node | ||
import pytest | ||
|
||
from ..site import AdminSite, AdminSiteInvalidNodeError, Node | ||
|
||
|
||
def test_admin_site_validate_nodes_raises_error_if_node_has_invalid_parent(): | ||
site = AdminSite() | ||
|
||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
namespace="test", | ||
parent="invalid", | ||
) | ||
|
||
with pytest.raises(AdminSiteInvalidNodeError) as exc_info: | ||
site.validate_nodes() | ||
|
||
assert str(exc_info.value) == ( | ||
"Misago Admin node 'misago:admin:invalid:test:index' has " | ||
"an invalid parent 'misago:admin:invalid'." | ||
) | ||
|
||
|
||
def test_admin_site_validate_nodes_raises_error_if_node_has_invalid_after(): | ||
site = AdminSite() | ||
|
||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
namespace="parent", | ||
) | ||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
parent="parent", | ||
namespace="second", | ||
after="invalid", | ||
) | ||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
parent="parent", | ||
namespace="first", | ||
) | ||
|
||
with pytest.raises(AdminSiteInvalidNodeError) as exc_info: | ||
site.validate_nodes() | ||
|
||
assert str(exc_info.value) == ( | ||
"Misago Admin node 'misago:admin:parent:second:index' has " | ||
"an invalid after node 'misago:admin:parent:invalid'." | ||
) | ||
|
||
|
||
def test_admin_site_validate_nodes_raises_error_if_node_has_invalid_before(): | ||
site = AdminSite() | ||
|
||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
namespace="parent", | ||
) | ||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
parent="parent", | ||
namespace="second", | ||
before="invalid", | ||
) | ||
site.add_node( | ||
name="Test", | ||
icon="test", | ||
parent="parent", | ||
namespace="first", | ||
) | ||
|
||
with pytest.raises(AdminSiteInvalidNodeError) as exc_info: | ||
site.validate_nodes() | ||
|
||
assert str(exc_info.value) == ( | ||
"Misago Admin node 'misago:admin:parent:second:index' has " | ||
"an invalid before node 'misago:admin:parent:invalid'." | ||
) | ||
|
||
|
||
def test_node_is_added_at_end_of_parent_children(): | ||
master = Node(name="Apples", link="misago:index") | ||
parent = Node(name="Apples", link="misago:index") | ||
child = Node(name="Oranges", link="misago:index") | ||
master.add_node(child) | ||
parent.add_node(child) | ||
|
||
assert master.children()[-1].name == child.name | ||
assert parent.children()[-1].name == child.name | ||
|
||
|
||
def test_add_node_after(): | ||
"""add_node added node after specific node""" | ||
master = Node(name="Apples", link="misago:index") | ||
parent = Node(name="Apples", link="misago:index") | ||
|
||
child = Node(name="Oranges", link="misago:index") | ||
master.add_node(child) | ||
parent.add_node(child) | ||
|
||
test = Node(name="Potatoes", link="misago:index") | ||
master.add_node(test, after="misago:index") | ||
parent.add_node(test, after="misago:index") | ||
|
||
all_nodes = master.children() | ||
all_nodes = parent.children() | ||
for i, node in enumerate(all_nodes): | ||
if node.name == test.name: | ||
assert all_nodes[i - 1].name == child.name | ||
|
||
|
||
def test_add_node_before(): | ||
"""add_node added node before specific node""" | ||
master = Node(name="Apples", link="misago:index") | ||
parent = Node(name="Apples", link="misago:index") | ||
|
||
child = Node(name="Oranges", link="misago:index") | ||
master.add_node(child) | ||
parent.add_node(child) | ||
|
||
test = Node(name="Potatoes", link="misago:index") | ||
master.add_node(test, before="misago:index") | ||
parent.add_node(test, before="misago:index") | ||
|
||
all_nodes = master.children() | ||
all_nodes = parent.children() | ||
for i, node in enumerate(all_nodes): | ||
if node.name == test.name: | ||
assert all_nodes[i + 1].name == child.name |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters