Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page #1780

Merged
merged 28 commits into from
Aug 3, 2024
Merged

Login page #1780

merged 28 commits into from
Aug 3, 2024

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Aug 1, 2024

Adds login page that works without JavaScript

TODO

  • Make "Sign in" button in navs link to login page.
  • Add social auth buttons
  • Add "forgotten password" link
  • Return 404 if LOGIN_URL is not current url (means site owner replaced login page with custom one)
  • Display banned page if user is banned
  • Display sign in fallback page if auth is delegated
  • Add decorator that renders login page for anonymous users. Support custom header message, redirect back to the page after successful login.
  • Support next arg in POST and GET
  • Make login links in emails point to new login page
  • Do only redirect to next page if user is already signed in
  • Add template outlets above and below login form
  • Make view responsive
  • Write tests for auth checks
    • Account is inactive (user activation)
    • Account is inactive (admin activation)
    • Account is deactivated
    • Account is banned (admin account)

Fixes #544

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) feature: auth This issue involves auth feature: admin Affects admin control panel labels Aug 1, 2024
@rafalp rafalp added this to the Next feature release milestone Aug 1, 2024
@rafalp rafalp self-assigned this Aug 1, 2024
@coveralls
Copy link

coveralls commented Aug 1, 2024

Coverage Status

coverage: 97.456% (-0.02%) from 97.477%
when pulling 41f9307 on fix-544-add-login-page
into 7109be4 on main.

@rafalp rafalp merged commit 281d09d into main Aug 3, 2024
1 check passed
@rafalp rafalp deleted the fix-544-add-login-page branch August 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node feature: admin Affects admin control panel feature: auth This issue involves auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-modal login page
2 participants