Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raiden-contracts to 0.24.0 #4275

Merged

Conversation

pirapira
Copy link
Contributor

I expect some tests to fail because the ABI of contracts changed.

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #4275 into develop will decrease coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4275      +/-   ##
===========================================
- Coverage    81.79%   81.78%   -0.02%     
===========================================
  Files          103      103              
  Lines        13438    13432       -6     
  Branches      2040     2037       -3     
===========================================
- Hits         10992    10985       -7     
- Misses        1864     1865       +1     
  Partials       582      582
Impacted Files Coverage Δ
raiden/utils/typing.py 94.23% <ø> (-0.11%) ⬇️
raiden/network/proxies/utils.py 92.3% <ø> (+6.59%) ⬆️
raiden/exceptions.py 97.5% <100%> (ø) ⬆️
raiden/network/blockchain_service.py 78.12% <100%> (+0.17%) ⬆️
raiden/settings.py 100% <100%> (ø) ⬆️
raiden/transfer/channel.py 91.1% <100%> (+0.01%) ⬆️
raiden/network/pathfinding.py 91.45% <100%> (+0.04%) ⬆️
raiden/network/proxies/service_registry.py 95.55% <100%> (-0.1%) ⬇️
raiden/transfer/state_change.py 98.76% <100%> (ø) ⬆️
raiden/network/proxies/token_network.py 65.5% <100%> (-0.17%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023cbf2...da2e453. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #4275 into develop will decrease coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4275      +/-   ##
===========================================
- Coverage    81.79%   81.78%   -0.02%     
===========================================
  Files          103      103              
  Lines        13438    13432       -6     
  Branches      2040     2037       -3     
===========================================
- Hits         10992    10985       -7     
- Misses        1864     1865       +1     
  Partials       582      582
Impacted Files Coverage Δ
raiden/utils/typing.py 94.23% <ø> (-0.11%) ⬇️
raiden/network/proxies/utils.py 92.3% <ø> (+6.59%) ⬆️
raiden/exceptions.py 97.5% <100%> (ø) ⬆️
raiden/network/blockchain_service.py 78.12% <100%> (+0.17%) ⬆️
raiden/settings.py 100% <100%> (ø) ⬆️
raiden/transfer/channel.py 91.1% <100%> (+0.01%) ⬆️
raiden/network/pathfinding.py 91.45% <100%> (+0.04%) ⬆️
raiden/network/proxies/service_registry.py 95.55% <100%> (-0.1%) ⬇️
raiden/transfer/state_change.py 98.76% <100%> (ø) ⬆️
raiden/network/proxies/token_network.py 65.5% <100%> (-0.17%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023cbf2...da2e453. Read the comment docs.

@pirapira
Copy link
Contributor Author

I still need to add the check for the onchain bytecode.

@codecov-io
Copy link

Codecov Report

Merging #4275 into develop will decrease coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4275      +/-   ##
===========================================
- Coverage    81.79%   81.78%   -0.02%     
===========================================
  Files          103      103              
  Lines        13438    13432       -6     
  Branches      2040     2037       -3     
===========================================
- Hits         10992    10985       -7     
- Misses        1864     1865       +1     
  Partials       582      582
Impacted Files Coverage Δ
raiden/utils/typing.py 94.23% <ø> (-0.11%) ⬇️
raiden/network/proxies/utils.py 92.3% <ø> (+6.59%) ⬆️
raiden/exceptions.py 97.5% <100%> (ø) ⬆️
raiden/network/blockchain_service.py 78.12% <100%> (+0.17%) ⬆️
raiden/settings.py 100% <100%> (ø) ⬆️
raiden/transfer/channel.py 91.1% <100%> (+0.01%) ⬆️
raiden/network/pathfinding.py 91.45% <100%> (+0.04%) ⬆️
raiden/network/proxies/service_registry.py 95.55% <100%> (-0.1%) ⬇️
raiden/transfer/state_change.py 98.76% <100%> (ø) ⬆️
raiden/network/proxies/token_network.py 65.5% <100%> (-0.17%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023cbf2...fa14c6d. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@60afd1a). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #4275   +/-   ##
=========================================
  Coverage           ?   81.2%           
=========================================
  Files              ?     105           
  Lines              ?   13713           
  Branches           ?    2102           
=========================================
  Hits               ?   11135           
  Misses             ?    1982           
  Partials           ?     596
Impacted Files Coverage Δ
raiden/network/proxies/user_deposit.py 63.33% <ø> (ø)
raiden/network/proxies/utils.py 92.3% <ø> (ø)
raiden/exceptions.py 97.56% <100%> (ø)
raiden/network/proxies/secret_registry.py 77.77% <100%> (ø)
raiden/settings.py 100% <100%> (ø)
raiden/network/proxies/token_network_registry.py 78.65% <100%> (ø)
raiden/network/proxies/service_registry.py 86.2% <100%> (ø)
raiden/network/proxies/token.py 74.66% <100%> (ø)
raiden/network/proxies/token_network.py 56.8% <100%> (ø)
raiden/utils/typing.py 94.33% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60afd1a...ba1428a. Read the comment docs.

@pirapira
Copy link
Contributor Author

@palango @rakanalh have another look, please.

raiden/network/rpc/client.py Outdated Show resolved Hide resolved
requirements/requirements.txt Show resolved Hide resolved
pirapira added a commit to pirapira/raiden that referenced this pull request Jul 2, 2019
@hackaugusto hackaugusto merged commit 144e01e into raiden-network:develop Jul 3, 2019
@pirapira pirapira deleted the raiden-contracts-0-24-0 branch July 3, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants