Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep global delete action related wording intact #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artemv
Copy link

@artemv artemv commented Feb 9, 2018

also,

  • show Restore button at Show page only if it's archived
  • show Delete button at Show page only if it's archived
  • removed unneeded to_s...constantize sequences

Notice that if you have custom archive action related translations
you'll need to rename and move them similar to how this commit does in
en.yml.

fixes #10

also,
* show Restore button at Show page only if it's archived
* show Delete button at Show page only if it's archived
* removed unneeded to_s...constantize sequences

Notice that if you have custom archive action related translations
you'll need to rename and move them similar to how this commit does in
en.yml.

fixes raihan2006i#10
@raihan2006i
Copy link
Owner

@artemv Thanks for the pull request, apologies for replying after long time. I will test and merge this during 🎄 holidays

@ndbroadbent
Copy link
Collaborator

@artemv This looks excellent, thanks! I am pulling your change into my fork. I still use ActiveAdmin and paranoia, so this gem is really helpful! It still works great even though it hasn't been updated for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Archive" label becomes global
3 participants