Skip to content

Commit

Permalink
Merge pull request #54 from rails/ci-tweaks
Browse files Browse the repository at this point in the history
Further tweaks to the self-CI setup
  • Loading branch information
matthewd authored Jun 23, 2023
2 parents 154bf8f + 8f9779b commit 0fadee1
Showing 1 changed file with 18 additions and 3 deletions.
21 changes: 18 additions & 3 deletions buildkite-config-initial-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,28 @@
steps:
- block: "Review Build Script"
prompt: |
Approval is required. Please review the changes carefully before unblocking.
Our CI scripts run outside the docker containers, which are a necessary security layer.
Approving a build here is equivalent to copy & pasting it into a production ssh window.
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
- @matthewd
- trigger: "rails-ci"
label: ":pipeline: Run buildkite-config CI"
label: ":pipeline: Build Rails main with new config"
build:
message: "${BUILDKITE_REPO} ${BUILDKITE_MESSAGE} (${BUILDKITE_BRANCH})"
message: "[${BUILDKITE_BRANCH}] ${BUILDKITE_MESSAGE}"
branch: "main"
env:
CONFIG_REPO: "${BUILDKITE_PULL_REQUEST_REPO}"
CONFIG_BRANCH: "${BUILDKITE_BRANCH}"
BUILDKITE_CONFIG_TRIGGER: true # This variable can be used downstream to avoid things like "if branch==main do Y"
- trigger: "rails-ci"
label: ":pipeline: Build Rails 6-1-stable with new config"
build:
message: "[${BUILDKITE_BRANCH} / 6-1-stable] ${BUILDKITE_MESSAGE}"
branch: "6-1-stable"
env:
CONFIG_REPO: "${BUILDKITE_PULL_REQUEST_REPO}"
CONFIG_BRANCH: "${BUILDKITE_BRANCH}"
BUILDKITE_CONFIG_TRIGGER: true # This variable can be used downstream to avoid things like "if branch==main do Y"

0 comments on commit 0fadee1

Please sign in to comment.