feat: allow request with x509 cert #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerrySong
approved these changes
Jul 14, 2023
PerrySong
approved these changes
Jul 14, 2023
Cool, I will try to find some time next weekend to set up a (or two) unit test(s)~ added the unit test with self signed client and server certificates at d8a7c57 |
|
Hi @rakyll , hope to get a review from you; thx! |
rockycookie
force-pushed
the
support-cert
branch
2 times, most recently
from
96d6821
to
2386ee8
Compare
rockycookie
force-pushed
the
support-cert
branch
from
2386ee8
to
23f2f2f
Compare
rockycookie
force-pushed
the
support-cert
branch
from
23f2f2f
to
547241f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support x509 client cert auth with
-certand-cert-key; while I realized there has been a similar work done at #172 after I made this change lolI would like to see either PR get merged; thx!I would like to merge this PR as I added unit test here lol