Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between page title and opengraph title #55

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

Voltra
Copy link
Contributor

@Voltra Voltra commented Dec 18, 2023

  • Add an opengraph_title column to the seo table
  • Add an openGraphTitle property to SEOData
  • Use SEOData#openGraphTitle over SEOData#title where it makes sense

Closes #53

@ralphjsmit
Copy link
Owner

Thank you, this looks good!

I have only one comment, which is to remove the migration please. Currently the seo table contains a very limited nr. of columns and similar overrides also don't have their own column.

Of course you are free to add this column to your own database yourself using a migration in your prefer, but for the package I'd prefer to not add migrations unless strictly necessary. Adding migrations to packages is generally a difficult thing. Eg if you just publish a migration, then people might not always have the migration in their project as well in minor version updates. If such a migration misses and people have the Model::preventAccessingMissingAttributes() enabled, then their code will now suddenly throw errors for missing attributes.

Let me know once you updated and then I'll merge. Thanks!

@Voltra
Copy link
Contributor Author

Voltra commented Dec 20, 2023

I've dropped the use of a migration for the open graph title

@ralphjsmit ralphjsmit merged commit eebd11c into ralphjsmit:main Dec 20, 2023
7 of 9 checks passed
@ralphjsmit
Copy link
Owner

Thanks! Released in 1.4.3 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for <title> and og:title to be different
2 participants