Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Templates: document machineInventoryAnnotations rendering #380

Merged

Conversation

fgiudici
Copy link
Member

We now render also the machineInventoryAnnotations items: update the docs.
While there, add some minor improvements to the Label Templates section.

Related to: rancher/elemental-operator#833

@fgiudici fgiudici self-assigned this Sep 20, 2024
@fgiudici fgiudici requested a review from a team as a code owner September 20, 2024 13:59
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit 59f9ca2
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/66f266de54b22f00084c9e8e
😎 Deploy Preview https://deploy-preview-380--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

We now render also the machineInventoryAnnotations items: update the
docs.
While there, add some minor improvements to the Label Templates section.

Signed-off-by: Francesco Giudici <[email protected]>
@fgiudici fgiudici force-pushed the label-templates-annotation-rendering branch from cb87af9 to 59f9ca2 Compare September 24, 2024 07:14
@fgiudici fgiudici enabled auto-merge (squash) September 24, 2024 07:14
@fgiudici fgiudici merged commit 5c616d6 into rancher:main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants