Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom installation docs #425

Merged

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Oct 22, 2024

This adapts the documentation around custom installation options. Former docs were done before we had SeedImage resources in place, nowadays most of the manual ISO crafting described there is no longer needed.

In addition the whole section is moved under the HowTo section.

Fixes #417

@davidcassany davidcassany requested a review from a team as a code owner October 22, 2024 11:49
Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit 836f020
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/6718d88c1f9a7200087c4bfb
😎 Deploy Preview https://deploy-preview-425--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidcassany davidcassany force-pushed the update_custom_installation_options branch 3 times, most recently from 6cefa71 to e91dc87 Compare October 22, 2024 12:09
@davidcassany
Copy link
Contributor Author

All this documentation is also valid for v1.6, so my plan is including this change to v1.6 after a first round of reviews.

@davidcassany davidcassany force-pushed the update_custom_installation_options branch from e91dc87 to 8deaad2 Compare October 22, 2024 12:52
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks. Amazing improvement overall! Nice to read all of this.
Also agreed this can be backported to 1.6.

docs/custom-install.md Outdated Show resolved Hide resolved
docs/custom-install.md Outdated Show resolved Hide resolved
docs/custom-install.md Outdated Show resolved Hide resolved
@davidcassany davidcassany force-pushed the update_custom_installation_options branch from 6b6dabd to 1265358 Compare October 23, 2024 10:54
@davidcassany davidcassany merged commit f0281c3 into rancher:main Oct 23, 2024
5 checks passed
@davidcassany davidcassany deleted the update_custom_installation_options branch October 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Review and update LVM example in docs
2 participants