This deals with incompatibilities between clang and gcc regarding names of function target attribute isas for arm targets #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3491 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 617 617
Lines 70384 70384
Branches 6820 6820
=======================================
+ Hits 62087 62091 +4
- Misses 5439 5440 +1
+ Partials 2858 2853 -5 see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
oviano
force-pushed
the
fix-clang-arm-function-target-attributes
branch
from
75f3153
to
e14dcae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with the warnings described in #3487
From clang 16.0.0 there is greater compatibility between the two compilers regarding this but since Apple clang has only just upgraded to clang 15.0 with Xcode 14.3 it seems that is some way off at least within the Apple ecosystem.