Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PK_Signature_Options #4318

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

Add PK_Signature_Options #4318

wants to merge 42 commits into from

Commits on Nov 1, 2024

  1. Add PK_Signature_Options 

    This allows controlling all details of how signatures are created,
without having to stuff values into the single parameters string
which was previously available.
    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    98f9b00 View commit details
    Browse the repository at this point in the history

  2. Fix TPM

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2c633fc View commit details
    Browse the repository at this point in the history

  3. Fix include

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    aacc762 View commit details
    Browse the repository at this point in the history

  4. Add Asymmetric_Key::supports_context_data

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    932f615 View commit details
    Browse the repository at this point in the history

  5. Cleanup provider handling

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    35e8dc6 View commit details
    Browse the repository at this point in the history

  6. Improve validation

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    212351f View commit details
    Browse the repository at this point in the history

  7. fmt

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3a15aa8 View commit details
    Browse the repository at this point in the history

  8. Missing add

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ab61a27 View commit details
    Browse the repository at this point in the history

  9. Attempt workaround for MSVC bug

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c284e9c View commit details
    Browse the repository at this point in the history

  10. Fix bogus include

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    88d31d2 View commit details
    Browse the repository at this point in the history

  11. Fix XMSS cli test

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    dbf1d07 View commit details
    Browse the repository at this point in the history

  12. Update verification

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    337b924 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: René Meusel <[email protected]>
    @randombit @reneme
    randombit and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f26e63e View commit details
    Browse the repository at this point in the history

  14. Fix typo

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    72e3a81 View commit details
    Browse the repository at this point in the history

  15. More stuff 

    Make hash optional, add salt len (needed for PSS)

Push options type down into EMSA (partially)
    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    454b42f View commit details
    Browse the repository at this point in the history

  16. Gut EMSA parsing logic

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    92b5dc5 View commit details
    Browse the repository at this point in the history

  17. Temporarily disable two tests that need fixing

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    455f9ef View commit details
    Browse the repository at this point in the history

  18. fixes

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c2512b0 View commit details
    Browse the repository at this point in the history

  19. value_or

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d4e7bce View commit details
    Browse the repository at this point in the history

  20. fixes

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0e93767 View commit details
    Browse the repository at this point in the history

  21. Handle explicit trailer fields

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b025b41 View commit details
    Browse the repository at this point in the history

  22. Fixes

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6f75c8e View commit details
    Browse the repository at this point in the history

  23. f

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5163ff3 View commit details
    Browse the repository at this point in the history

  24. Update some cli, examples, tests

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c04b241 View commit details
    Browse the repository at this point in the history

  25. fmt

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c1be281 View commit details
    Browse the repository at this point in the history

  26. Move

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    90d854b View commit details
    Browse the repository at this point in the history

  27. shim

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ddad2c7 View commit details
    Browse the repository at this point in the history

  28. f

    @randombit @reneme
    randombit authored and reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6a71101 View commit details
    Browse the repository at this point in the history

  29. Introduce a base builder as discussed here: #4318 (comment)

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a4b80e2 View commit details
    Browse the repository at this point in the history

  30. Consumers can specify expectations of value availability 

    As discussed: https://github.com/randombit/botan/pull/4318\#issuecomment-2340834399
    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    88af001 View commit details
    Browse the repository at this point in the history

  31. Split Options and Builder into two classes 

    As discussed: https://github.com/randombit/botan/pull/4318\#issuecomment-2340834399
    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    efd60ad View commit details
    Browse the repository at this point in the history

  32. Disentangle pk_keys.h and pubkey.h with fwd declares

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    589524a View commit details
    Browse the repository at this point in the history

  33. Go all-in on the builder pattern 

    as mentioned here: https://github.com/randombit/botan/pull/4318\#issuecomment-2297990007
    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    04fa277 View commit details
    Browse the repository at this point in the history

  34. remove half-baked c'tors of PK_Signer/Verifier 

    as discussed: https://github.com/randombit/botan/pull/4318\#issuecomment-2297990007
    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c82da41 View commit details
    Browse the repository at this point in the history

  35. .with_provider() filters out legacy 'base' provider

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e07e48c View commit details
    Browse the repository at this point in the history

  36. PK_Signature_Options::from_legacy() 

    Without this patch, clang seemed to miscompile the retrofitting of the
PK_Signer() legacy constructor. valgrind complained about uninitialized
memory when building with clang in -O2 and -O3 (didn't test -O1).
    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d2d4e63 View commit details
    Browse the repository at this point in the history

  37. Code cleanup in base classes

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    89a8964 View commit details
    Browse the repository at this point in the history

  38. Cleanups

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a4ef95a View commit details
    Browse the repository at this point in the history

  39. Dilithium can't deal with context/prehash yet

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    aa04f2a View commit details
    Browse the repository at this point in the history

  40. Options<>::to_string() can render uint8_t buffers

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9c79af7 View commit details
    Browse the repository at this point in the history

  41. Test: OptionsBuilder

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d3dbcc2 View commit details
    Browse the repository at this point in the history

  42. Fix after rebase

    @reneme
    reneme committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9d8cee0 View commit details
    Browse the repository at this point in the history