Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control characters not being sanitized from shared strings in 1.3.6 #345

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Aug 15, 2014

  1. Extracted control char sanitization to module level and applied to sh…

    …ared strings table output.
    
    Conflicts:
    	lib/axlsx/workbook/shared_strings_table.rb
    randym authored and tcannonfodder committed Aug 15, 2014
    Configuration menu
    Copy the full SHA
    f8ef8eb View commit details
    Browse the repository at this point in the history
  2. Add test to confirm control characters are removed from shared strings

    * Commit f8ef8eb fixed the shared
      strings class to automatically sanitize its serialized XML output to
      remove any control characters. However, this commit did not include
      tests that the shared strings actually removed the control
      characters when serializing to an XML string.
      * This tests confirms that the string with control characters is
        added to the shared strings, and that the control characters are
        removed from the string in question when serialized to XML.
    tcannonfodder committed Aug 15, 2014
    Configuration menu
    Copy the full SHA
    c6a07b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2014

  1. hide version

    Conflicts:
    	lib/axlsx/version.rb
    tcannonfodder committed Sep 23, 2014
    Configuration menu
    Copy the full SHA
    aab304d View commit details
    Browse the repository at this point in the history