Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataTypeValidator.validate
is slower thenv.is_a?(ClassName)
%{< ... }
is faster thenstr << ('<c r="' << ...)
values.size.times do |index|
is faster thenvalues.each_with_index do |value, index|
DateTimeConverter.date_to_serial
~ 1.8 times faster, because avoid creating date object and making rational calculation each time. I trydate.to_time.to_i
anddate.strftime("%s").to_i
- second is much faster. But it rounds to secondsOverall improvement is small, but for each specific method about 50% faster when compare with
benchmark-ips