Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dracula theme from https://draculatheme.com/ranger #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flexbusterman
Copy link

No description provided.

@toonn
Copy link
Member

toonn commented Mar 6, 2024

I'm not opposed to including this colorscheme but I'm unsure of the right way to do it. Maybe it should be a submodule? I kind of want to avoid manually copying any updates on the dracula/ranger repository.

@thalesnunes, as maintainer, any opinions on including the colorscheme here?

@hut
Copy link
Member

hut commented Mar 6, 2024

It's unlikely that there will be many updates (if any). It has been created in 2021 and has since been unchanged. I would just copy it, with a link to the original repository somewhere.

@thalesnunes
Copy link

As @hut commented, I doubt any change will be made to this, unless something major changes in ranger.
Anyways, I think a submodule would be the best way to go, and if ranger can't read folders recursively, maybe a symlink to the file inside the submodule's directory...
What do you guys think?

@toonn
Copy link
Member

toonn commented Mar 30, 2024

I agree a submodule would be better, keep the single source of truth. I know submodule UX is not great but since the theme won't change much it's also not going to come up much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants