feat(wallets): add evm to tron link #350
Conversation
| @@ -21,8 +21,8 @@ | |||
| "parserOptions": { | |||
| "ecmaVersion": "latest", | |||
| "sourceType": "module", | |||
| // "project": ["tsconfig.base.json"] | |||
There was a problem hiding this comment.
@yeager-eren
please check eslint parser issue
| const { tronLink, TronLinkEVM } = window; | ||
|
|
||
| if (!tronLink) { | ||
| return tronLink; |
There was a problem hiding this comment.
| return tronLink; | |
| return null; |
Make it more explicit.
| @@ -23,27 +30,63 @@ export const config = { | |||
| defaultNetwork: Networks.TRON, | |||
There was a problem hiding this comment.
Default network is tron, When you are on Ethereum network on TronLink, it goes through an error. How we can fix it?
| if (!r) { | ||
| const results: ProviderConnectResult[] = []; | ||
|
|
||
| if (ethInstance) { |
There was a problem hiding this comment.
It tries to connect to Ethereum and Tron (instance) at the same time but the wallet seems doesn't support that and one network should be connected at the same time.
|
|
||
| ethInstance?.on('accountsChanged', (addresses: string[]) => { | ||
| const eth_chainId = meta | ||
| .filter(isEvmBlockchain) |
There was a problem hiding this comment.
Is this line need as long as you have a find?
| ethInstance?.on('accountsChanged', (addresses: string[]) => { | ||
| const eth_chainId = meta | ||
| .filter(isEvmBlockchain) | ||
| .find((blockchain) => blockchain.name === Networks.ETHEREUM)?.chainId; |
There was a problem hiding this comment.
Do we need to support for BSC as well?
| .filter(isEvmBlockchain) | ||
| .find((blockchain) => blockchain.name === Networks.ETHEREUM)?.chainId; | ||
| if (state.connected) { | ||
| if (state.network != Networks.ETHEREUM && eth_chainId) { |
There was a problem hiding this comment.
I'm not sure why we need this condition here.
|
|
||
| export const getSigners: (provider: any) => SignerFactory = signer; | ||
|
|
||
| export const getWalletInfo: (allBlockChains: BlockchainMeta[]) => WalletInfo = ( | ||
| allBlockChains | ||
| ) => { | ||
| const evms = evmBlockchains(allBlockChains); |
There was a problem hiding this comment.
It returns the whole list evm compatible networks, but we only need BSC and ETH here as the wallet only has support for this.
No description provided.