Add the debug files to the copy commands for "make-windows" #711
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dledda-r7
reviewed
Sep 20, 2024
| @@ -13,11 +13,13 @@ install-windows: | |||
| @echo "Installing Windows payloads" | |||
| ifneq ("$(wildcard c/meterpreter/output/*.x86.dll)","") | |||
| @cp c/meterpreter/output/*.x86.dll $(METERPDIR) | |||
| @cp c/meterpreter/output/*.x86.debug.dll $(METERPDIR) | |||
There was a problem hiding this comment.
This generate an error if there are no debug builds present.
┌──(kali㉿kali)-[~/Documents/github/metasploit-payloads]
└─$ make install-windows
Installing Windows payloads
cp: cannot stat 'c/meterpreter/output/*.x86.debug.dll': No such file or directory
make: *** [Makefile:15: install-windows] Error 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
make install-windowscommand last week, I found myself troubleshooting unexpected behavior becausemake install-windowsfailed to move the debug versions of the files over, and if they're not present, then (as expected) there's no warning that the old debug stuff is used. This just adds the debug dlls to the list of files copied to thedata/meterpreterdirectory of framework.Testing:
metasploit-framework/data/meterpreter