Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modifications to polls and stories API #851

Merged
merged 10 commits into from
Jan 12, 2022
Merged

Conversation

alviriseup
Copy link
Contributor

Added modifications to polls and stories API call to solve the following two issues: #850 and #835

ureport/api/serializers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests

ureport/api/tests.py Outdated Show resolved Hide resolved
Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run the script ./code_check.py

@codecov-commenter
Copy link

Codecov Report

Merging #851 (28bc7d0) into main (ce1bba6) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   81.88%   82.02%   +0.13%     
==========================================
  Files          44       44              
  Lines        4632     4667      +35     
==========================================
+ Hits         3793     3828      +35     
  Misses        839      839              
Impacted Files Coverage Δ
ureport/api/views.py 97.75% <ø> (ø)
ureport/api/serializers.py 94.96% <100.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce1bba6...28bc7d0. Read the comment docs.

Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alvi

@norkans7 norkans7 merged commit d69a4d4 into rapidpro:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants