Remove "legacy" Dask DataFrame support from Dask cuDF #17558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
…to remove-legacy-dataframe
jameslamb
approved these changes
Dec 16, 2024
galipremsagar
approved these changes
Dec 16, 2024
Comment on lines
+16
to
+17
| "The legacy DataFrame API is not supported in dask_cudf>24.12. " | ||
| "Please enable query-planning, or downgrade to dask_cudf<=24.12" |
There was a problem hiding this comment.
Suggested change
| "The legacy DataFrame API is not supported in dask_cudf>24.12. " | |
| "Please enable query-planning, or downgrade to dask_cudf<=24.12" | |
| "The legacy DataFrame API is not supported in dask_cudf>24.12." | |
| "Please enable query-planning, or downgrade to dask_cudf<=24.12" |
There was a problem hiding this comment.
Don't we want a space between the period and the first word of the next sentence?
This was referenced Dec 16, 2024
|
Update: This is blocked by rapidsai/dask-cuda#1417 (which is now ready for review) |
…to remove-legacy-dataframe
|
Update: This PR now removes 2,000+ lines of code that would be essentially "dead" outside the legacy API. |
|
/okay to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The legacy Dask DataFrame API is deprecated. We should remove it for 25.02 to reduce maintenance burden.
Blockers:
Checklist