Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pragma GCC diagnostic from source files #17637

Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Open

Remove pragma GCC diagnostic from source files #17637

wants to merge 1 commit into from

Conversation

davidwendt
Copy link
Contributor

Description

Removes the #pragma GCC diagnostic from several source files. These do not seem to be necessary and could suppress useful compile warnings.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 19, 2024
@davidwendt davidwendt self-assigned this Dec 19, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 19, 2024 22:21
@vyasr
Copy link
Contributor

vyasr commented Dec 20, 2024

@robertmaynard these were added in #14726. Has something changed in our compilation since then to make these pragmas unnecessary? Perhaps a change to our compiler toolchain?

@davidwendt
Copy link
Contributor Author

No compile warnings appear in the CI logs. I tested with a debug build as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@lamarrr lamarrr Awaiting requested review from lamarrr lamarrr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vyasr vyasr Awaiting requested review from vyasr

At least 1 approving review is required to merge this pull request.

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidwendt @vyasr