Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DataFrameGroupBy.get_group was raising with length>1 tuples #17653

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Fix: DataFrameGroupBy.get_group was raising with length>1 tuples #17653

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcdfa96
fix: DataFrameGroupBy.get_group was raising with length>1 tuples
MarcoGorelli Dec 23, 2024
b0fd0d6
Merge branch 'branch-25.02' into get-group-2-tuple
bdice Dec 23, 2024
fdd6508
Update python/cudf/cudf/tests/test_groupby.py
MarcoGorelli Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cudf/cudf/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ def get_group(self, name, obj=None):
"instead of ``gb.get_group(name, obj=df)``.",
FutureWarning,
)
if is_list_like(self._by):
if is_list_like(self._by) and len(self._by) == 1:
if isinstance(name, tuple) and len(name) == 1:
name = name[0]
else:
Expand Down
7 changes: 7 additions & 0 deletions python/cudf/cudf/tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4076,6 +4076,13 @@ def test_get_group_list_like():
df.groupby(["a"]).get_group([1])


def test_get_group_list_like_len_2():
df = cudf.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6], 'c': [3, 2, 1]})
MarcoGorelli marked this conversation as resolved.
Show resolved Hide resolved
result = df.groupby(["a", "b"]).get_group((1, 4))
expected = df.to_pandas().groupby(["a", "b"]).get_group((1, 4))
assert_eq(result, expected)


def test_size_as_index_false():
df = pd.DataFrame({"a": [1, 2, 1], "b": [1, 2, 3]}, columns=["a", "b"])
expected = df.groupby("a", as_index=False).size()
Expand Down
Loading