Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] cuspatial v24.06 #1391

Merged
merged 17 commits into from
Jun 5, 2024
Merged

[RELEASE] cuspatial v24.06 #1391

merged 17 commits into from
Jun 5, 2024

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-24.06 and v24.06 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-24.06 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-24.06 into main for the release

raydouglass and others added 16 commits March 15, 2024 11:59
@raydouglass
DOC v24.06 Updates [skip ci]
5727015
@GPUtester
Merge pull request #1362 from rapidsai/branch-24.04
2800b06 
Forward-merge branch-24.04 to branch-24.06
@GPUtester
Merge pull request #1367 from rapidsai/branch-24.04
bebeb1a 
Forward-merge branch-24.04 into branch-24.06
@GPUtester
Merge pull request #1372 from rapidsai/branch-24.04
9451d13 
Forward-merge branch-24.04 into branch-24.06
@galipremsagar
Enable all tests for arm jobs (#1365)
e42de2f 
* run all pytests for arm jobs

* Delete ci/wheel_smoke_test_cuproj.py

* Delete ci/wheel_smoke_test_cuspatial.py
@mroeschke
Enable pytest failures on warnings on FutureWarnings (Replace depreca…
c5203dc 
…ted `geopandas.dataset` module) (#1360)

Continuing the effort in rapidsai/build-planning#26 by enabling `FutureWarnings` and `DeprecationWarnings` to raise errors in the CI.

The primary change here is to replace `geopandas.dataset` usage with the files used (the data in https://github.com/geopandas/geopandas/tree/main/geopandas/tests/data)

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: #1360
@harrism
Replace rmm::mr::device_memory_resource* with rmm::device_async_resou…
76762fc 
…rce_ref (#1373)

Closes #1371

Replaces all occurrences of `rmm::mr::device_memory_resource*` in parameters with `rmm::device_async_resource_ref`.  Also updates guidance in the DEVELOPER_GUIDE.md

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - Michael Wang (https://github.com/isVoid)

URL: #1373
@trxcllnt
Always use a static gtest and gbench (#1377)
37f35f8 
Use static GTest and Benchmark.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Michael Wang (https://github.com/isVoid)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1377
@mroeschke
Enable warnings-as-errors for cuproj tests (#1379)
2e83746 
Following rapidsai/build-planning#26, enabled warnings-as-errors for cuproj test

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

URL: #1379
@hcho3
Migrate to {{ stdlib("c") }} (#1376)
83e332c 
The `sysroot*` syntax is getting phased out (conda-forge/conda-forge.github.io#2102).
The recommendation is to move to `{{ stdlib("c") }}`.

Ref rapidsai/build-planning#39

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1376
@trxcllnt
Fix JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test (#1346)
0324a33 
The `JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP` test isn't returning any points because they aren't evenly distributed.

The first commit adds a check to ensure the test fails when no results are returned. The second commit fixes the `JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP` test.

Fixes #1380.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1346
@trxcllnt
add --rm and --name to devcontainer run args (#1375)
d80834f 
* Update the `cuda11.8-conda` devcontainer's base image
* Remove the devcontainer when the VSCode window closes
* Adds a descriptive name to the running container:
  ```shell
  $ docker ps -a
  CONTAINER ID   IMAGE              ...  NAMES
  0dbb364fe544   vsc-cuspatial-...  ...  rapids-cuspatial-24.06-cuda12.2-conda
  
  $ docker rm -f rapids-cuspatial-24.06-cuda12.2-conda
  ```

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1375
@vyasr
Fix up imports (#1383)
61b8cc1
@msarahan
create conda ci test env in one step (#1387)
eff6753 
This is a port of rapidsai/cuml#5781 and part of rapidsai/build-planning#22

Authors:
  - Mike Sarahan (https://github.com/msarahan)
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Paul Taylor (https://github.com/trxcllnt)
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1387
@trxcllnt
Fix quadtree spatial join OOMs on large numbers of input polygons (#1381
8840189 
)

Followup to #1346.

* Fixes some typos/omissions in types and CMake.
* Adds a new test that OOMs when quadtree_point_in_polygon is passed too many input polygons.
* Fixes quadtree spatial join to handle overflow while counting and more conservatively allocate output buffers.

Fixes #890.

* [Failing test run](https://github.com/rapidsai/cuspatial/actions/runs/8979838628/job/24662981350#step:7:840)
* [Passing test run](https://github.com/rapidsai/cuspatial/actions/runs/8981106226/job/24666403165#step:7:840)

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Michael Wang (https://github.com/isVoid)

URL: #1381
@trxcllnt
Fix building cuspatial with CCCL main (#1382)
559bcc7 
Similar to rapidsai/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1382
@raydouglass raydouglass requested review from a team as code owners May 31, 2024 13:18
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added conda Related to conda and conda configuration cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library ci labels May 31, 2024
@raydouglass raydouglass merged commit 0da4274 into main Jun 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
ci cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@raydouglass @GPUtester @galipremsagar @mroeschke @harrism @trxcllnt @hcho3 @vyasr @msarahan