-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] cuspatial v24.10 #1466
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 44a296c - Browse repository at this point
Copy the full SHA 44a296cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 536f67b - Browse repository at this point
Copy the full SHA 536f67bView commit details
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 71b7a1a - Browse repository at this point
Copy the full SHA 71b7a1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e155a3 - Browse repository at this point
Copy the full SHA 3e155a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7ec971 - Browse repository at this point
Copy the full SHA f7ec971View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35e4cc1 - Browse repository at this point
Copy the full SHA 35e4cc1View commit details -
Merge branch 'fix-update-version-dependencies-alpha-spec' into branch…
…-24.10-merge-24.08
Configuration menu - View commit details
-
Copy full SHA for 84dd6aa - Browse repository at this point
Copy the full SHA 84dd6aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60b1787 - Browse repository at this point
Copy the full SHA 60b1787View commit details -
Merge pull request #1410 from jakirkham/branch-24.10-merge-24.08
Forward-merge branch-24.08 into branch-24.10
Configuration menu - View commit details
-
Copy full SHA for 5eca3b4 - Browse repository at this point
Copy the full SHA 5eca3b4View commit details
Commits on Jul 31, 2024
-
Merge pull request #1419 from rapidsai/branch-24.08
Forward-merge branch-24.08 into branch-24.10
Configuration menu - View commit details
-
Copy full SHA for b195ac7 - Browse repository at this point
Copy the full SHA b195ac7View commit details
Commits on Aug 1, 2024
-
Merge pull request #1423 from rapidsai/branch-24.08
Forward-merge branch-24.08 into branch-24.10
Configuration menu - View commit details
-
Copy full SHA for 12b226a - Browse repository at this point
Copy the full SHA 12b226aView commit details
Commits on Aug 7, 2024
-
Merge pull request #1431 from rapidsai/branch-24.08
Forward-merge branch-24.08 into branch-24.10
Configuration menu - View commit details
-
Copy full SHA for 8ffb204 - Browse repository at this point
Copy the full SHA 8ffb204View commit details -
Address cudf.DataFrame.insert API change (#1428)
closes #1427 The API of `cudf.DataFrame.insert` will change in 24.10 to better align with pandas, so adjusting the usage here xref rapidsai/cudf#16402 Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Mark Harris (https://github.com/harrism) URL: #1428
Configuration menu - View commit details
-
Copy full SHA for 3906fb9 - Browse repository at this point
Copy the full SHA 3906fb9View commit details -
Pass columns instead of Series to
cudf.DataFrame
in split-combine w……orkflow (#1429) closes #1426 It appears there was a change in 24.08 that broke a notebook demonstrating a `merge` on two geometry columns. It seems like the merge result tries to reconstruct a `GeoDataFrame` from a `dict[Any, GeoSeries | Series]` but the `Series.index` alignment requires the types to be recognized cudf types (not `"geometry"`) I don't think this alignment is entirely necessary though since it goes through the `_split_out_geometry_columns`/`_recombine_columns` methods which appears to be used on operations that maintain row ordering so index alignment isn't required. This PR instead passes a `dict[Any, GeoColumn | Column]` to `cudf.DataFrame._from_data` given that this row ordering is preserved. (This PR also includes the fix for #1427) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Mark Harris (https://github.com/harrism) URL: #1429
Configuration menu - View commit details
-
Copy full SHA for 6865f7c - Browse repository at this point
Copy the full SHA 6865f7cView commit details
Commits on Aug 9, 2024
-
Disallow GeoSeries from accepting a column in favor of
_from_column
(……#1434) closes #1433 Mirroring the upstream cudf changes in rapidsai/cudf#16454, `cudf.Series` disallows accepting a `ColumnBase` in favor of the `cudf.Series._from_column` constructor. This PR does the same for `GeoSeries` as well as addresses the breakages due to the upstream cudf change. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) URL: #1434
Configuration menu - View commit details
-
Copy full SHA for 1b60fb7 - Browse repository at this point
Copy the full SHA 1b60fb7View commit details -
Update pre-commit hooks (#1435)
This PR updates pre-commit hooks to the latest versions that are supported without causing style check errors. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #1435
Configuration menu - View commit details
-
Copy full SHA for e708625 - Browse repository at this point
Copy the full SHA e708625View commit details -
Improve update-version.sh (#1432)
A few small tweaks to `update-version.sh` for alignment across RAPIDS. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - James Lamb (https://github.com/jameslamb) URL: #1432
Configuration menu - View commit details
-
Copy full SHA for 3780822 - Browse repository at this point
Copy the full SHA 3780822View commit details
Commits on Aug 12, 2024
-
Use tool.scikit-build.cmake.version, set scikit-build-core minimum-ve…
…rsion (#1430) Contributes to rapidsai/build-planning#58. `scikit-build-core==0.10.0` was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it. This proposes upgrading to that version and fixing configuration here in a way that: * is compatible with that new `scikit-build-core` version * takes advantage of the forward-compatibility mechanism (`minimum-version`) that `scikit-build-core` provides, to reduce the risk of needing to do this again in the future Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - https://github.com/jakirkham URL: #1430
Configuration menu - View commit details
-
Copy full SHA for 93a1653 - Browse repository at this point
Copy the full SHA 93a1653View commit details
Commits on Aug 13, 2024
-
Fix _recombine_columns when either geocolumn or non-geocolumn was emp…
…ty (#1438) closes #1437 When `GeoDataFrame._split_out_geometry_columns` is called, there may be no geometry columns to split out into 2 DataFrames; therefore, once `GeoDataFrame._recombine_columns`, it assumed the 2 DataFrames were always non-empty. Added a check to bypass this validation if either was empty. I ran the `ZipCodes_Stops_PiP_cuSpatial` notebook locally and the (non-commented) cells no longer raise an exception. Authors: - Matthew Roeschke (https://github.com/mroeschke) - James Lamb (https://github.com/jameslamb) Approvers: - Mark Harris (https://github.com/harrism) URL: #1438
Configuration menu - View commit details
-
Copy full SHA for 314dc7d - Browse repository at this point
Copy the full SHA 314dc7dView commit details -
ensure notebook-testing script fails when notebooks fail (#1424)
The notebook-testing CI job in this repo does not actually cause a loud CI failure if any errors are detected in notebooks. That's because of a `bash` mistake I made in #1407... that PR moved notebook-checking into a function, but didn't add a `set -E` to be sure errors from inside that function were appropriately trapped. This PR fixes that: * ensures that notebook failures actually cause CI failures * fixes 2 typos in `nyc_taxi_years_correlation.ipynb` code - *(not caught in #1422 because of this CI script bug)* Context: #1422 (review) ## Notes for Reviewers ### How I tested this Originally did not skip any notebooks. Saw the failures in one of the notebooks cause an actual merge-blocking CI failure. Build link: https://github.com/rapidsai/cuspatial/actions/runs/10199784404/job/28219162698?pr=1424 # Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Mark Harris (https://github.com/harrism) - https://github.com/jakirkham URL: #1424
Configuration menu - View commit details
-
Copy full SHA for 82f321b - Browse repository at this point
Copy the full SHA 82f321bView commit details
Commits on Aug 15, 2024
-
Remove unused shuffle_order in GeoColumn (#1439)
With rapidsai/cudf#16549, `cudf.Index` no longer accepts `Column` objects. The only usage I found was that `GeoColumn` accepted `shuffle_order=cudf.Index(column)`, but `shuffle_order` appears unused (anymore?) in `GeoColumn`, so I went ahead and removed this from the constructor Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1439
Configuration menu - View commit details
-
Copy full SHA for 5842315 - Browse repository at this point
Copy the full SHA 5842315View commit details
Commits on Aug 19, 2024
-
Update cuspatial to use pylibcudf (#1440)
This is necessary for compatibility with cudf after rapidsai/cudf#16299. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) URL: #1440
Configuration menu - View commit details
-
Copy full SHA for c60bd4d - Browse repository at this point
Copy the full SHA c60bd4dView commit details
Commits on Aug 21, 2024
-
Internal linkage kernels (#1436)
Mark all cuspatial CUDA kernels with internal linkage to avoid runtime symbol collisions. Also updated the CI tests to also verify that we add no new CUDA kernel with external linkage. Authors: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) URL: #1436
Configuration menu - View commit details
-
Copy full SHA for f678ad5 - Browse repository at this point
Copy the full SHA f678ad5View commit details -
Add data=None to ListColumn constructor (#1442)
Post rapidsai/cudf#16465, the `data` argument to `ListColumn` is a required argument (as `None`) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1442
Configuration menu - View commit details
-
Copy full SHA for 5dd14ef - Browse repository at this point
Copy the full SHA 5dd14efView commit details
Commits on Aug 23, 2024
-
Drop Python 3.9 support (#1443)
Contributes to rapidsai/build-planning#88 Finishes the work of dropping Python 3.9 support. This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235. This PR updates configuration and docs to reflect that. ## Notes for Reviewers ### How I tested this Checked that there were no remaining uses like this: ```shell git grep -E '3\.9' git grep '39' git grep 'py39' ``` And similar for variations on Python 3.8 (to catch things that were missed the last time this was done). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mark Harris (https://github.com/harrism) - https://github.com/jakirkham URL: #1443
Configuration menu - View commit details
-
Copy full SHA for e323178 - Browse repository at this point
Copy the full SHA e323178View commit details
Commits on Aug 29, 2024
-
wheels: dynamically load
libcudf.so
fromlibcudf
wheel (#1447)Contributes to rapidsai/build-planning#33. Proposes the following for `cuspatial` wheels: * add build and runtime dependencies on `libcudf` wheels * stop vendoring copies of `libcudf.so`, `libnvcomp.so`, `libnvcomp_bitcomp.so`, and `libnvcomp_gdeflate.so` - *(load `libcudf.so` dynamically at runtime instead)* And other related changes for development/CI: * combine all `pip install` calls into 1 in wheel-testing scripts - *like rapidsai/cudf#16575 - *to improve the chance that packaging issues are discovered in CI* * `dependencies.yaml` changes: - more use of YAML anchors = less duplication - use dedicated `depends_on_librmm` and `depends_on_libcudf` groups * explicitly pass a package type to `gha-tools` wheel uploading/downloading scripts ## Notes for Reviewers ### Benefits of these changes Unblocks CI in this repo (ref: #1444 (comment), #1441 (comment)). Reduces wheel sizes for `cuspatial` wheels by about 125MB 😁 | wheel | size (before) | size (this PR) | |:-----------:|-------------:|---------------:| | `cuspatial` | 146.0M | 21M | | `cuproj ` | 0.9M | 0.9M | |**TOTAL** | **146.9M** | **21.9M** | *NOTES: size = compressed, "before" = 2024-08-21 nightlies (c60bd4d), CUDA = 12, Python = 3.11* <details><summary>how I calculated those (click me)</summary> ```shell # note: 2024-08-21 because that was the most recent date with # successfully-built cuspatial nightlies # docker run \ --rm \ -v $(pwd):/opt/work:ro \ -w /opt/work \ --network host \ --env RAPIDS_NIGHTLY_DATE=2024-08-21 \ --env RAPIDS_NIGHTLY_SHA=c60bd4d \ --env RAPIDS_PR_NUMBER=1447 \ --env RAPIDS_PY_CUDA_SUFFIX=cu12 \ --env RAPIDS_REPOSITORY=rapidsai/cuspatial \ --env WHEEL_DIR_BEFORE=/tmp/wheels-before \ --env WHEEL_DIR_AFTER=/tmp/wheels-after \ -it rapidsai/ci-wheel:cuda12.5.1-rockylinux8-py3.11 \ bash mkdir -p "${WHEEL_DIR_BEFORE}" mkdir -p "${WHEEL_DIR_AFTER}" py_projects=( cuspatial cuproj ) for project in "${py_projects[@]}"; do # before RAPIDS_BUILD_TYPE=nightly \ RAPIDS_PY_WHEEL_NAME="${project}_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REF_NAME="branch-24.10" \ RAPIDS_SHA=${RAPIDS_NIGHTLY_SHA} \ rapids-download-wheels-from-s3 python "${WHEEL_DIR_BEFORE}" # after RAPIDS_BUILD_TYPE=pull-request \ RAPIDS_PY_WHEEL_NAME="${project}_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REF_NAME="pull-request/${RAPIDS_PR_NUMBER}" \ rapids-download-wheels-from-s3 python "${WHEEL_DIR_AFTER}" done du -sh ${WHEEL_DIR_BEFORE}/* du -sh ${WHEEL_DIR_BEFORE} du -sh ${WHEEL_DIR_AFTER}/* du -sh ${WHEEL_DIR_AFTER} ``` </details> Reduces the amount of additional work required to start shipping `libcuspatial` wheels. ### Background This is part of ongoing work towards packaging `libcuspatial` as a wheel. relevant prior work: * packaging `libcudf` wheels: rapidsai/cudf#15483 * consolidating `pip install` calls in CI scripts for `cudf`: rapidsai/cudf#16575 * `cudf` dropping its Arrow library dependency: rapidsai/cudf#16640 ### How I tested this Confirmed in local builds and CI logs that `cudf` is being *found*, not *built*, in `cuspatial` builds. ```text -- CPM: Using local package [email protected] ``` ([build link](https://github.com/rapidsai/cuspatial/actions/runs/10602971716/job/29386288614?pr=1447#step:9:23472)) Built `cuspatial` wheels locally and ran all the unit tests, without issue. # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) - Matthew Roeschke (https://github.com/mroeschke) URL: #1447
Configuration menu - View commit details
-
Copy full SHA for b43a32e - Browse repository at this point
Copy the full SHA b43a32eView commit details -
Update rapidsai/pre-commit-hooks (#1445)
This PR updates rapidsai/pre-commit-hooks to the version 0.4.0. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - James Lamb (https://github.com/jameslamb) Approvers: - James Lamb (https://github.com/jameslamb) URL: #1445
Configuration menu - View commit details
-
Copy full SHA for b61c052 - Browse repository at this point
Copy the full SHA b61c052View commit details -
cuproj: depend on librmm, not rmm (#1448)
Contributes to rapidsai/build-planning#33 `cuproj` does not need the `rmm` Python package... it only needs the RMM headers at build time. This proposes the following changes for `cuproj`: * dropping the runtime requirement on `rmm` in wheels and conda packages * switching the build requirement from `rmm` to `librmm` for wheels and conda packages * removing unnecessary imports in the `test:` environment for conda packages For more context on these changes, see rapidsai/build-planning#92. ## Notes for Reviewers ### Benefits of these changes Faster conda builds (via dropping unnecessary dependencies). Cheaper (in terms of bandwidth and disk space) installation of wheels and conda packages (via removing an unnecessary runtime dependency). Reduces a source of network calls (and therefore CI instability) by removing some CPM downloads of RMM. Before: ```text -- CPM: Adding package [email protected] (branch-24.10) ``` ([build link](https://github.com/rapidsai/cuspatial/actions/runs/10618529204/job/29434041322#step:9:16754)) After (this PR): ```text -- CPM: Using local package [email protected] ``` ([build link](https://github.com/rapidsai/cuspatial/actions/runs/10619138604/job/29436119470?pr=1448#step:9:11256)) ### Is this required for `libcuspatial` wheel packaging? No, it's just a side thing I noticed while working on that. The two are totally independent. # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1448
Configuration menu - View commit details
-
Copy full SHA for 9c616de - Browse repository at this point
Copy the full SHA 9c616deView commit details
Commits on Aug 30, 2024
-
cuproj: remove pin on 'proj' in conda packages (#1449)
Proposes removing the `cuproj` conda package's pin on `proj`, so that it can build using the same version that `conda-forge` pins to in https://github.com/conda-forge/conda-forge-pinning-feedstock. For context, see: * why the `proj==9.3.0` pin was originally added: #1307 * `conda-forge` completied migrations: - `9.3.1`: conda-forge/conda-forge-pinning-feedstock#5401 - `9.4.`: conda-forge/conda-forge-pinning-feedstock#6240 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham URL: #1449
Configuration menu - View commit details
-
Copy full SHA for 1544e7b - Browse repository at this point
Copy the full SHA 1544e7bView commit details
Commits on Sep 4, 2024
-
fix wheel tests on Rocky Linux (#1452)
RAPIDS libraries recently started running nightly wheel tests on Rocky Linux 8: https://github.com/rapidsai/shared-workflows/pull/236/files#r1725947245 That distribution's system package manager is `yum`, not `apt`, and as a result `cuspatial`'s nightly runs are failing like this: ```text ci/test_wheel_cuspatial.sh: line 10: apt: command not found Error: Process completed with exit code 127. ``` ([build link](https://github.com/rapidsai/cuspatial/actions/runs/10678284262/job/29595047179)) This fixes that. ## Notes for Reviewers ### How I tested this ```shell docker run \ --rm \ --gpus 1 \ -v $(pwd):/opt/work \ -w /opt/work \ -it rapidsai/citestwheel:cuda12.5.1-rockylinux8-py3.11 \ bash yum update -y yum config-manager --set-enabled powertools yum update -y yum install -y gdal-devel python -m pip install \ --no-binary fiona \ 'cuproj-cu12[test]==24.10.*,>=0.0.0a0' \ 'cuspatial-cu12[test]==24.10.*,>=0.0.0a0' \ 'fiona>=1.8.19,<1.9' pushd python/cuproj/cuproj python -m pytest \ --cache-clear \ --numprocesses=8 \ --dist=worksteal \ tests popd pushd python/cuspatial/cuspatial python -m pytest \ --cache-clear \ --numprocesses=8 \ --dist=worksteal \ tests popd ``` # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1452
Configuration menu - View commit details
-
Copy full SHA for e07d66c - Browse repository at this point
Copy the full SHA e07d66cView commit details -
Distribute libcuspatial wheels (#1450)
Contributes to rapidsai/build-planning#33 Adds `libcuspatial` wheels, and switches `cuspatial` wheels to using them. ## Notes for Reviewers ### Benefits of these changes Faster CI runs and smaller total footprint on package repositories (because now `libcuspatial` no longer needs to be compiled once per Python version). Smaller `cuspatial` wheels. | whee. l | size (before) | size (this PR) | |:-------------:|-------------:|----------------:| | `libcuspatial` | --- | 17.0M | | `cuspatial`. | 21.0M | 4.1M | | `cuproj ` | 0.9M | 0.9M | |**TOTAL** | **21.9M** | **22.0M** | *NOTES: size = compressed, "before" = 2024-09-02 nightlies (1544e7b), CUDA = 12, Python = 3.11* <details><summary>how I calculated those (click me)</summary> ```shell docker run \ --rm \ -v $(pwd):/opt/work:ro \ -w /opt/work \ --network host \ --env RAPIDS_NIGHTLY_DATE=2024-09-02 \ --env RAPIDS_NIGHTLY_SHA=1544e7b \ --env RAPIDS_PR_NUMBER=1450 \ --env RAPIDS_PY_CUDA_SUFFIX=cu12 \ --env RAPIDS_REPOSITORY=rapidsai/cuspatial \ --env WHEEL_DIR_BEFORE=/tmp/wheels-before \ --env WHEEL_DIR_AFTER=/tmp/wheels-after \ -it rapidsai/ci-wheel:cuda12.5.1-rockylinux8-py3.11 \ bash mkdir -p "${WHEEL_DIR_BEFORE}" mkdir -p "${WHEEL_DIR_AFTER}" py_projects=( cuspatial cuproj ) for project in "${py_projects[@]}"; do # before RAPIDS_BUILD_TYPE=nightly \ RAPIDS_PY_WHEEL_NAME="${project}_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REF_NAME="branch-24.10" \ RAPIDS_SHA=${RAPIDS_NIGHTLY_SHA} \ rapids-download-wheels-from-s3 python "${WHEEL_DIR_BEFORE}" # after RAPIDS_BUILD_TYPE=pull-request \ RAPIDS_PY_WHEEL_NAME="${project}_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REF_NAME="pull-request/${RAPIDS_PR_NUMBER}" \ rapids-download-wheels-from-s3 python "${WHEEL_DIR_AFTER}" done # after RAPIDS_BUILD_TYPE=pull-request \ RAPIDS_PY_WHEEL_NAME="libcuspatial_${RAPIDS_PY_CUDA_SUFFIX}" \ RAPIDS_REF_NAME="pull-request/${RAPIDS_PR_NUMBER}" \ rapids-download-wheels-from-s3 cpp "${WHEEL_DIR_AFTER}" du -sh ${WHEEL_DIR_BEFORE}/* du -sh ${WHEEL_DIR_BEFORE} du -sh ${WHEEL_DIR_AFTER}/* du -sh ${WHEEL_DIR_AFTER} ``` </details> ### devcontainers job? Once this PR is close to ready, let's merge the devcontainers PR and then re-run the devcontainers CI here. devcontainers PR: rapidsai/devcontainers#387 ### `rapids-metadata` changes? Not necessary, `libcuspatial` is already there: https://github.com/rapidsai/rapids-metadata/blob/9b6307e708511cd9a1990d8bb36606df53bc9e1b/src/rapids_metadata/__init__.py#L89 # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1450
Configuration menu - View commit details
-
Copy full SHA for 0e9d36c - Browse repository at this point
Copy the full SHA 0e9d36cView commit details
Commits on Sep 6, 2024
-
re-enable mixing libcuspatial wheels with libcudf conda packages (#1456)
Fixes #1455 devcontainer conda CI jobs are failing in this project because of the following mix of characteristics for thoes jobs: * all build and runtime dependencies for `libcuspatial`, `cuspatial`, `cuproj` are installed via conda * `libcuspatial`, `cuspatial`, and `cuproj` wheels are then built with `pip install -e --no-deps --no-build-isolation` * `import libcuspatial` results in unconditionally running `import libcudf` * `libcudf` is provided by the `libcudf` **conda** package, which does not have any Python modules, so that import fails This fixes that, and restores the ability to mix a `pip install`'d `cuspatial` / `cuproj` with a `conda`-installed `libcudf`. ## Notes for Reviewers ### How did CI not catch this before? When rapidsai/devcontainers#387 was merged, I only re-ran the **pip** devcontainers CI job on #1450. # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1456
Configuration menu - View commit details
-
Copy full SHA for 9385e49 - Browse repository at this point
Copy the full SHA 9385e49View commit details
Commits on Sep 9, 2024
-
rearrange dependencies.yaml, fix development instructions (#1451)
Follow-up to #1448. This proposes some `dependencies.yaml` changes that I noticed while working on adding `libcuspatial` wheels in #1450. I've left inline comments with more details, but in short: * not including any cuspatial projects in the conda environment files checked into this repo (which are intended to be used to set up a development environment) * removing an unnecessary conda-only list of dependencies from pyproject.toml-specific config for `cuproj` * introduction of `depends_on_libcuspatial` and `depends_on_cuproj` lists in `dependencies.yaml`, to reduce duplication Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1451
Configuration menu - View commit details
-
Copy full SHA for 0bbd71d - Browse repository at this point
Copy the full SHA 0bbd71dView commit details -
Add support for Python 3.12, ping proj back to 9.3.x, require geopand…
…as>=1.0 (#1453) Contributes to rapidsai/build-planning#40 This PR adds support for Python 3.12. ## Notes for Reviewers This is part of ongoing work to add Python 3.12 support across RAPIDS. It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213. A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all RAPIDS repos have added Python 3.12 support. Other changes required to add that support: * pinning `proj` back to 9.3.x, reverting #1449 (#1453 (comment)) * requiring `geopandas >= 1.0` (#1453 (comment)) ### This will fail until all dependencies have been updates to Python 3.12 CI here is expected to fail until all of this project's upstream dependencies support Python 3.12. This can be merged whenever all CI jobs are passing. Authors: - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1453
Configuration menu - View commit details
-
Copy full SHA for 2a30f5f - Browse repository at this point
Copy the full SHA 2a30f5fView commit details
Commits on Sep 17, 2024
-
Recommending
miniforge
for conda install (#1457)Recommending `miniforge` for conda install in build instructions. Authors: - Mike McCarty (https://github.com/mmccarty) Approvers: - Mark Harris (https://github.com/harrism) URL: #1457
Configuration menu - View commit details
-
Copy full SHA for 3df7128 - Browse repository at this point
Copy the full SHA 3df7128View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a2d21c9 - Browse repository at this point
Copy the full SHA a2d21c9View commit details
Commits on Sep 20, 2024
-
Update flake8 to 7.1.1. (#1458)
We need to update flake8 to fix a false-positive that appears with older flake8 versions on Python 3.12. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - James Lamb (https://github.com/jameslamb) URL: #1458
Configuration menu - View commit details
-
Copy full SHA for 43776f2 - Browse repository at this point
Copy the full SHA 43776f2View commit details
Commits on Sep 24, 2024
-
Remove NumPy <2 pin, remove proj pin (#1441)
This PR removes the NumPy<2 pin which is expected to work for RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had some issues preventing the use with NumPy 2). Also contributes to rapidsai/build-planning#56 by removing the pin on `proj` (which allows this project to work with newer `fmt` / `spdlog`, in sync with conda-forge). Authors: - Sebastian Berg (https://github.com/seberg) - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) - https://github.com/jakirkham Approvers: - Bradley Dice (https://github.com/bdice) URL: #1441
Configuration menu - View commit details
-
Copy full SHA for be73c8e - Browse repository at this point
Copy the full SHA be73c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d94bec - Browse repository at this point
Copy the full SHA 3d94becView commit details
Commits on Sep 25, 2024
-
Switch
traceback
tonative
in pytests (#1464)In cudf & cuml we have observed a ~10% to ~20% respectively speed up of pytest suite execution by switching pytest traceback to `--native`: ``` currently: 102474 passed, 2117 skipped, 902 xfailed in 892.16s (0:14:52) --tb=short: 102474 passed, 2117 skipped, 902 xfailed in 898.99s (0:14:58) --tb=no: 102474 passed, 2117 skipped, 902 xfailed in 815.98s (0:13:35) --tb=native: 102474 passed, 2117 skipped, 902 xfailed in 820.92s (0:13:40) ``` This PR makes similar change to `cuspatial` repo. xref: rapidsai/cudf#16851 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Bradley Dice (https://github.com/bdice) - Paul Taylor (https://github.com/trxcllnt) URL: #1464
Configuration menu - View commit details
-
Copy full SHA for d4835ee - Browse repository at this point
Copy the full SHA d4835eeView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cc8fd60 - Browse repository at this point
Copy the full SHA cc8fd60View commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77c893a - Browse repository at this point
Copy the full SHA 77c893aView commit details