Moving random ball cover #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #218 +/- ##
=============================================
Coverage 70.37% 70.37%
=============================================
Files 12 12
Lines 54 54
=============================================
Hits 38 38
Misses 16 16 ☔ View full report in Codecov by Sentry. |
benfred
reviewed
Jul 18, 2024
| @@ -0,0 +1,205 @@ | |||
| /* | |||
There was a problem hiding this comment.
nitpick: since we're no longer header only - I'd prefer to get rid of having -ext.cuh and -inl.cuh header files.
There was a problem hiding this comment.
Do you mean just consolidate them into one file or do you mean remove the intantiations / ignored extern templates?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Linking #110 |
|
/ok to test |
|
/ok to test |
|
Metrics are showing this change adds ~78mb to the overall binary size. This is not acceptable.
|
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Oct 4, 2024
This PR updates to use cuVS instead of RAFT for vector search, pairwise distances and clustering. This is required for us to deprecate the vector search functionality in RAFT, in favour of the code in cuVS. Because some code hasn't been migrated over to cuvs yet, we will continue to use the version in RAFT - but with RAFT in header only mode. In particular this functionality will be used in RAFT header only mode: * Random Ball Cover (see rapidsai/cuvs#218) * Sparse KNN * nn-descent rapidsai/cuvs#364 * [MetricProcessor](c7d1b0e) * knn_merge_parts * build_dendrogram_host * build_sorted_mst * raft DistanceType Because sparse KNN in RAFT uses the DistanceType in RAFT, we can't fully move over to use the DistanceType code in cuVS with this PR. (Also the DistanceType code in RAFT has a `Precomputed` option that isn't available in cuvs - but is needed by cuml for dbscan.) This means that we have both the raft and cuvs DistanceType enum's in use with this change, with conversions between them. Authors: - Ben Frederickson (https://github.com/benfred) - Bradley Dice (https://github.com/bdice) - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) - Bradley Dice (https://github.com/bdice) URL: #6085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.