Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add pinned memory resource to C API #311

Open
wants to merge 1 commit into
base: branch-24.10
Choose a base branch
from

Conversation

ajit283
Copy link
Contributor

@ajit283 ajit283 commented Aug 30, 2024

Let me know if this is out of scope for cuVS!

@ajit283 ajit283 requested a review from a team as a code owner August 30, 2024 15:15
Copy link

copy-pr-bot bot commented Aug 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet
Copy link
Member

cjnolet commented Sep 4, 2024

/ok to test

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 4, 2024
@cjnolet
Copy link
Member

cjnolet commented Sep 6, 2024

@ajit283 it would be a lot easier to review this PR (and faster to merge it) if you were to isolate the pinned memory resource from the go api changes.

@ajit283
Copy link
Contributor Author

ajit283 commented Sep 6, 2024

@cjnolet oh sorry, I didn't mean to include those at all

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants