Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to mark issues/prs as stale/rotten #525

Closed
wants to merge 1 commit into from

Conversation

jjacobelli
Copy link
Contributor

Issues and PRs without activity for 30d will be marked as stale.
If there is no activity for 90d, they will be marked as rotten.

Issues and PRs without activity for 30d will be marked as stale.
If there is no activity for 90d, they will be marked as rotten.

Signed-off-by: Jordan Jacobelli <[email protected]>
@jjacobelli jjacobelli requested a review from a team as a code owner February 12, 2021 10:32
@jjacobelli jjacobelli added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 12, 2021
@pentschev
Copy link
Member

Is that the case for all PRs or will it depend on other information, such as labels? For example, I have recently marked #402 and #326, which are both blocked by external factors, but I wouldn't like either of those to be marked as rotten.

@jjacobelli
Copy link
Contributor Author

Is that the case for all PRs or will it depend on other information, such as labels? For example, I have recently marked #402 and #326, which are both blocked by external factors, but I wouldn't like either of those to be marked as rotten.

Currently it's for all PRs. I think we should keep it this way to be sure we do not leave PRs as "blocked" despite the blocking condition is resolved. You will just need to comment the PR to remove the stale label every 30 days. WDYT?

@pentschev
Copy link
Member

I wouldn't mind doing that every 90 days or so, but these PRs may be there easily for 6+ months, as is the case of #326 , where we're blocked by a Dask feature that's currently on hold. Doing so every 30 days feels a bit annoying, that would mean we will end up having to do this roughly twice for every RAPIDS release.

@pentschev
Copy link
Member

Alternatively, could this changed only PRs that aren't marked as "Draft"? I think that would be a reasonable middle ground.

@jjacobelli jjacobelli added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 15, 2021
@jjacobelli
Copy link
Contributor Author

Hey @pentschev, I understand your point, but the idea here is to be able to track issues and PRs without activity. Ignoring some PRs/issues would be contrary to the objective. We want to be sure we are not letting any issue or PR open without reason and so by commenting every month, we are sure the blocking condition is evaluated again. WDYT?

@pentschev
Copy link
Member

Honestly, I think this is going to be a big annoyance, I would prefer if we could have a way to add exceptions to some PRs, even if it's just a label or something that would allow us a longer grace period for those marked in such a way.

@jjacobelli
Copy link
Contributor Author

Maybe we can create a specific label to ignore some PRs/issues
@mike-wendt WDYT?

@mike-wendt
Copy link
Contributor

@pentschev @madsbk I understand your position and agree it will add a few minutes to update these PRs monthly even to say still blocked. That said, this PR is a part of a RAPIDS wide update to ensure we're reviewing issues/PRs in a more timely manner, and enabling the PM team to track and respond to these issues/PRs. The 30 day stale window is to ensure all issues/PRs are reviewed each release, so we keep the relevant ones around and close those that are not being worked on. The 90 day rotten window should only exist at the start of implementing this across all RAPIDS repos as going forward we should be addressing these more quickly than 90 days. The ultimate goal is so the repos and the PM team can quickly target the oldest issues/PRs first and then keep the others updated to minimize the number of stale labels.

Feedback from @aravenel and @fondaing is that an issue/PR with several still blocked comments has much more context and value versus no updates in months on an issue/PR with a label 0 - Blocked. Given their feedback we should move forward with the current settings in this PR. Alex said he will follow up with the PICs next month after we have this implemented and are tracking the number of stale & rotten issues/PRs to see if adjustments need to be made. For now, let's start with these settings in use by other repos and meet with the PM team next month about adjustments.

@jjacobelli
Copy link
Contributor Author

Using this PR to resolve auto-merger issue: #528

@jjacobelli jjacobelli closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants