Skip to content

Commit

Permalink
Add explicit instantiations for IVF-PQ search kernels used in tests (#…
Browse files Browse the repository at this point in the history
…2212)

Compilation of IVF-PQ search kernels can be time consuming. In `libraft.so` the compilation is done in parallel for kernels without filtering and with `int64_t` index type.

We have test with `uint32_t` index type as well as tests for `bitset_filter` with both 32 and 64 bit index types. This PR adds explicit template instantiations for the test. This way we avoid repeated compilation of the kernels with filter and this also enables parallel compilation of the `compute_similarity` kernel for different template types. The kernels with these additional type parameters are not added to `libraft.so`, only linked together with the test executable.

Note that this PR does not increase the number of compiled kernels, but it enables to compile them in parallel.

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)

Approvers:
  - Artem M. Chirkin (https://github.com/achirkin)
  - Ben Frederickson (https://github.com/benfred)

URL: #2212
  • Loading branch information
tfeher authored and achirkin committed Mar 18, 2024
1 parent 80c45f1 commit 49b6b61
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 49b6b61

Please sign in to comment.