Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add distance epilogue for NN Descent #2364

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

jinsolp
Copy link
Contributor

@jinsolp jinsolp commented Jun 14, 2024

Adding distance epilogue to NN Descent.
Planning to use them for the following use cases as of now;

  • Calculating mutual reachability distance for HDBSCAN (possibly for usage with HDBSCAN - related PR here)
  • Enabling L2SqrtExpanded distance metric, by sqrt-ing the current supported metric (L2Expanded) of NN Descent in the distance epilogue. (for usage with UMAP - related PR here)

@jinsolp jinsolp requested a review from a team as a code owner June 14, 2024 21:49
@github-actions github-actions bot added the cpp label Jun 14, 2024
Copy link
Contributor

@tarang-jain tarang-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor suggestion.

cpp/include/raft/neighbors/detail/nn_descent.cuh Outdated Show resolved Hide resolved
cpp/include/raft/neighbors/detail/nn_descent.cuh Outdated Show resolved Hide resolved
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jinsolp for the PR, it looks good to me!

The only issue is that we are moving nearest neighbor code to cuVS, I have added a note to rapidsai/cuvs#170 to track this.

@tfeher tfeher added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 26, 2024
@jinsolp
Copy link
Contributor Author

jinsolp commented Jun 26, 2024

Thank you ☺️

Copy link

copy-pr-bot bot commented Jun 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@divyegala
Copy link
Member

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jul 2, 2024

/ok to test

@jinsolp
Copy link
Contributor Author

jinsolp commented Jul 11, 2024

/ok to test

1 similar comment
@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ab5e128 into rapidsai:branch-24.08 Jul 11, 2024
69 checks passed
@jinsolp jinsolp deleted the fea-nnd-dist-epilogue branch July 12, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants