Skip to content

Commit

Permalink
Remove now redundant trace logs from ucxx::RequestTagMulti
Browse files Browse the repository at this point in the history
Since `ucxx::RequestTagMulti` now inherits from `ucxx::Request`, the
latter's trace logging for creation/destruction are sufficient.
  • Loading branch information
pentschev committed Jul 28, 2023
1 parent 63d97f5 commit 4f69a0b
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions cpp/src/request_tag_multi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ RequestTagMulti::RequestTagMulti(std::shared_ptr<Endpoint> endpoint,
_send(send),
_tag(tag)
{
ucxx_trace_req("RequestTagMulti::RequestTagMulti: %p, send: %d, tag: %lx", this, send, _tag);

auto worker = endpoint->getWorker();
if (enablePythonFuture) _future = worker->getFuture();
}
Expand All @@ -50,7 +48,6 @@ RequestTagMulti::~RequestTagMulti()
*/
br->request = nullptr;
}
ucxx_trace("RequestTagMulti destroyed: %p", this);
}

std::shared_ptr<RequestTagMulti> createRequestTagMultiSend(std::shared_ptr<Endpoint> endpoint,
Expand All @@ -60,15 +57,12 @@ std::shared_ptr<RequestTagMulti> createRequestTagMultiSend(std::shared_ptr<Endpo
const ucp_tag_t tag,
const bool enablePythonFuture)
{
ucxx_trace_req("RequestTagMulti::tagMultiSend");
auto ret =
std::shared_ptr<RequestTagMulti>(new RequestTagMulti(endpoint, true, tag, enablePythonFuture));

if (size.size() != buffer.size() || isCUDA.size() != buffer.size())
throw std::runtime_error("All input vectors should be of equal size");

ucxx_trace("RequestTagMulti created: %p", ret.get());

ret->send(buffer, size, isCUDA);

return ret;
Expand All @@ -78,12 +72,9 @@ std::shared_ptr<RequestTagMulti> createRequestTagMultiRecv(std::shared_ptr<Endpo
const ucp_tag_t tag,
const bool enablePythonFuture)
{
ucxx_trace_req("RequestTagMulti::tagMultiRecv");
auto ret =
std::shared_ptr<RequestTagMulti>(new RequestTagMulti(endpoint, false, tag, enablePythonFuture));

ucxx_trace("RequestTagMulti created: %p", ret.get());

ret->recvCallback(UCS_OK);

return ret;
Expand Down

0 comments on commit 4f69a0b

Please sign in to comment.