-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix branch-0.34 forward merge conflicts #74
Fix branch-0.34 forward merge conflicts #74
Commits on Jul 26, 2023
-
Use gtest version from conda_build_config.yaml. (rapidsai#66)
This PR adds appropriate pinnings for `gtest` and `gmock` in `libucxx-tests`. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#66
Configuration menu - View commit details
-
Copy full SHA for 0e3c8aa - Browse repository at this point
Copy the full SHA 0e3c8aaView commit details
Commits on Aug 2, 2023
-
Fix destruction of
ucxx::RequestTagMulti
and final status (rapidsai#72) This PR introduces various fixes: * Fix destruction of `ucxx::RequestTagMulti`, which after moving to inheriting from `ucxx::Request`, using `setStatus()` was missing, thus causing the `ucxx::RequestTagMulti` to never cleanup its inflight request status. Calling `setStatus()` instead of writing the `_status` attribute directly resolves this. * The status of `ucxx::RequestTagMulti` was until now always `UCS_INPROGRESS` or `UCS_OK` after completing. This is not right but there is no good way to combine the statuses of all underlying requests. Therefore we now set the status of the first failing request as the final status instead of `UCS_OK` if at least one of the requests failed. The user can still check each underlying's request status if granular information is required. * Since `ucxx::RequestTagMulti` now inherits from `ucxx::Request`, the latter's trace logging for creation/destruction are sufficient, thus removing the redundant trace logs is appropriate. * Add lifetime trace logs for `ucxx::BufferRequest`. * Execute user-defined callback within the scope fo `ucxx::Request::setStatus()` to prevent accidental reordering mistakes, as the callback needs to always execute after the status is set, because the callback itself might make use of that information. Additionally it will prevent missing execution of the callback should `setStatus()` be called elsewhere in the future. * Return `std::shared_ptr<Buffer> in allocateBuffer()` as returning raw pointers may cause leaks, and can be problematic specifically in `ucxx::RequestTagMulti` as the `Buffer*` will not be released unless the user takes ownership and releases it appropriately. * Introduce mutex in `ucxx::Request` because of potential concurrency issues when running with the progress thread, which a mutex can resolve in `ucxx::Request`. A common case is when `ucxx::Endpoint` is registering an inflight request and `setStatus()` has just begun running, in which case the inflight request will be removed (a no-op as it hasn't been previously registered) and then actually registered, which will cause the `ucxx::Request` to never cleanup. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: rapidsai#72
Configuration menu - View commit details
-
Copy full SHA for 65deb67 - Browse repository at this point
Copy the full SHA 65deb67View commit details
Commits on Aug 3, 2023
-
Add capability to process generic callbacks in progress thread (rapid…
…sai#65) Implement and use generic callbacks to create endpoints, close endpoints and listeners, and probe tags. By doing this we ensure those don't need to take the UCS spinlock or progress the worker during the application thread, which can be sources of deadlocks. Authors: - Peter Andreas Entschev (https://github.com/pentschev) - Lawrence Mitchell (https://github.com/wence-) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: rapidsai#65
Configuration menu - View commit details
-
Copy full SHA for 98b6b89 - Browse repository at this point
Copy the full SHA 98b6b89View commit details
Commits on Aug 7, 2023
-
Merge remote-tracking branch 'upstream/branch-0.33' into branch-0.34-…
…merge-branch-0.33
Configuration menu - View commit details
-
Copy full SHA for f1d6099 - Browse repository at this point
Copy the full SHA f1d6099View commit details -
Merge remote-tracking branch 'upstream/branch-0.34' into branch-0.34-…
…merge-branch-0.33
Configuration menu - View commit details
-
Copy full SHA for 91a8bf0 - Browse repository at this point
Copy the full SHA 91a8bf0View commit details