Bust cache for CSS and JS on every build #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: #2991 To prevent stale versions of our stylesheets and JavaScript from being served after a deploy, ensure their URL is unique for each build by appending the time of the build (as seconds since the epoch) in a query string. This means we will bust the cache even if our CSS and JS don't change (as the query string changes on every build rather than being a function of the contents of the relevant file) but this errs on the side of caution and keeps the implementation very simple compared to introducing an asset pipeline. We only add the cache busting query string to files we change as opposed to vendored JavaScript (jQuery, etc.) as they shouldn't change without also updating their filename.
aallan
approved these changes
Sep 5, 2023
|
Nice 👍 |
mudge
added a commit
that referenced
this pull request
Oct 4, 2023
Following on from the work in #3097, ensure we bust the cache for boxes.css too which was missed in the first pass as it isn't included on every page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #2991
To prevent stale versions of our stylesheets and JavaScript from being served after a deploy, ensure their URL is unique for each build by appending the time of the build (as seconds since the epoch) in a query string.
This means we will bust the cache even if our CSS and JS don't change (as the query string changes on every build rather than being a function of the contents of the relevant file) but this errs on the side of caution and keeps the implementation very simple compared to introducing an asset pipeline.
We only add the cache busting query string to files we change as opposed to vendored JavaScript (jQuery, etc.) as they shouldn't change without also updating their filename.