Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future the linux kernel will be able to differentiate between IMX290, IMX327 and IMX462, see raspberrypi/linux#5859.
When the according device tree is configured, libcamera needs to adopt as well to support the newly reported camera type.
Tested as following:
libcamera-still -o "/home/pi/banding1.jpg" --shutter 100000 --gain 0 --awbgains 1,1 --immediate --raw -n --tuning-file /usr/share/libcamera/ipa/rpi/vc4/imx290.json
Question: I didn't bother tuning the new cameras. They probable deserve their own tuning due to having slightly different sensitivity, but I don't own the equipment to properly do so. Should we just go with the imx290 tuning file and copy that + rename to imx327/462.json? Or do we not add it to make it more clear that no good tuning is available, and that people should explicitly add their own tuning file (like I did in my example command)?