Skip to content

Commit

Permalink
overlays: gpio-keys: Avoid open-drain warnings
Browse files Browse the repository at this point in the history
The i2c-gpio driver expects to use a GPIO in open-drain mode. Failure
to configure it in that way causes alarming warnings in the kernel log.
The BCM283x and BCM2711 GPIO blocks don't support open-drain mode,
but i2c-gpio works anyway. Silence the warning by declaring that
open-drain mode has been enabled by other means.

See: raspberrypi/firmware#1381

Signed-off-by: Phil Elwell <[email protected]>
  • Loading branch information
pelwell authored and popcornmix committed May 11, 2020
1 parent fbd2e17 commit fb7adfd
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/arm/boot/dts/overlays/i2c-gpio-overlay.dts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
&gpio 24 0 /* scl */
>;
i2c-gpio,delay-us = <2>; /* ~100 kHz */
i2c-gpio,sda-open-drain;
i2c-gpio,scl-open-drain;
#address-cells = <1>;
#size-cells = <0>;
};
Expand Down

0 comments on commit fb7adfd

Please sign in to comment.