Skip to content

Commit

Permalink
mmc: block: disable CQ on SD cards when doing non-Discard erase
Browse files Browse the repository at this point in the history
Only CMD38 with Arg=0x1 (Discard) is supported when in CQ mode, so
turn it off before issuing a non-discard erase op.

Signed-off-by: Jonathan Bell <[email protected]>
  • Loading branch information
P33M authored and pelwell committed Oct 21, 2024
1 parent 914e24b commit fd8e764
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions drivers/mmc/core/block.c
Original file line number Diff line number Diff line change
Expand Up @@ -1223,12 +1223,26 @@ static void mmc_blk_issue_erase_rq(struct mmc_queue *mq, struct request *req,
unsigned int from, nr;
int err = 0;
blk_status_t status = BLK_STS_OK;
bool restart_cmdq = false;

if (!mmc_can_erase(card)) {
status = BLK_STS_NOTSUPP;
goto fail;
}

/*
* Only Discard ops are supported with SD cards in CQ mode
* (SD Physical Spec v9.00 4.19.2)
*/
if (mmc_card_sd(card) && card->ext_csd.cmdq_en && erase_arg != SD_DISCARD_ARG) {
restart_cmdq = true;
err = mmc_sd_cmdq_disable(card);
if (err) {
status = BLK_STS_IOERR;
goto fail;
}
}

from = blk_rq_pos(req);
nr = blk_rq_sectors(req);

Expand All @@ -1249,6 +1263,11 @@ static void mmc_blk_issue_erase_rq(struct mmc_queue *mq, struct request *req,
status = BLK_STS_IOERR;
else
mmc_blk_reset_success(md, type);

if (restart_cmdq)
err = mmc_sd_cmdq_enable(card);
if (err)
status = BLK_STS_IOERR;
fail:
blk_mq_end_request(req, status);
}
Expand Down

0 comments on commit fd8e764

Please sign in to comment.