can: isotp: add module parameter for maximum pdu size #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 96d1c81 upstream. With ISO 15765-2:2016 the PDU size is not limited to 2^12 - 1 (4095) bytes but can be represented as a 32 bit unsigned integer value which allows 2^32 - 1 bytes (~4GB). The use-cases like automotive unified diagnostic services (UDS) and flashing of ECUs still use the small static buffers which are provided at socket creation time. When a use-case requires to transfer PDUs up to 1025 kByte the maximum PDU size can now be extended by setting the module parameter max_pdu_size. The extended size buffers are only allocated on a per-socket/connection base when needed at run-time. changes since v2: https://lore.kernel.org/all/[email protected] - use ARRAY_SIZE() to reference DEFAULT_MAX_PDU_SIZE only at one place changes since v1: https://lore.kernel.org/all/[email protected] - limit the minimum 'max_pdu_size' to 4095 to maintain the classic behavior before ISO 15765-2:2016 Link: raspberrypi#5371 Signed-off-by: Oliver Hartkopp <[email protected]> Link: https://lore.kernel.org/all/[email protected] Signed-off-by: Marc Kleine-Budde <[email protected]>
|
See #5371. Waiting for user testing. |
|
I'm happy with this change, but will wait for some user feedback. |
|
Thanks folks! See my comment here: |
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Aug 7, 2023
kernel: drivers: media: i2c Updated imx296 driver for external trigger See: raspberrypi/linux#5560 kernel: overlays: Add bmp380 to i2c-sensor overlay See: raspberrypi/linux#5558 kernel: drivers: media: imx296: Add standby delay during probe See: raspberrypi/linux#5555 kernel: can: isotp: add module parameter for maximum pdu size See: raspberrypi/linux#5557 kernel: media: dt-bindings: imx258: Fix alternate compatible strings
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 9, 2023
kernel: drivers: media: i2c Updated imx296 driver for external trigger See: raspberrypi/linux#5560 kernel: overlays: Add bmp380 to i2c-sensor overlay See: raspberrypi/linux#5558 kernel: drivers: media: imx296: Add standby delay during probe See: raspberrypi/linux#5555 kernel: can: isotp: add module parameter for maximum pdu size See: raspberrypi/linux#5557 kernel: media: dt-bindings: imx258: Fix alternate compatible strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 96d1c81 upstream.
With ISO 15765-2:2016 the PDU size is not limited to 2^12 - 1 (4095) bytes but can be represented as a 32 bit unsigned integer value which allows 2^32 - 1 bytes (~4GB). The use-cases like automotive unified diagnostic services (UDS) and flashing of ECUs still use the small static buffers which are provided at socket creation time.
When a use-case requires to transfer PDUs up to 1025 kByte the maximum PDU size can now be extended by setting the module parameter max_pdu_size. The extended size buffers are only allocated on a per-socket/connection base when needed at run-time.
changes since v2: https://lore.kernel.org/all/[email protected]
changes since v1: https://lore.kernel.org/all/[email protected]
Link: #5371
Link: https://lore.kernel.org/all/[email protected]