Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CQE incremental fixes part 2 #6419

Merged
merged 6 commits into from
Oct 18, 2024
Merged

CQE incremental fixes part 2 #6419

merged 6 commits into from
Oct 18, 2024

Commits on Oct 18, 2024

  1. mmc: don't reference requests after finishing them 

    Posted write tracking introduced in the commit below raced with re-use
of the requests between completion and submission, potentially causing
underflow of the pending write count.

Fixes: e6c1e86 ("mmc: restrict posted write counts for SD cards in CQ mode")

Signed-off-by: Jonathan Bell <[email protected]>
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b890b17 View commit details
    Browse the repository at this point in the history

  2. Revert "mmc: sd: halt CQHCI before issuing a cache flush command" 

    __mmc_start_request turns CQE off before issuing the actual command so
this additional call is redundant.

This reverts commit 8e40644.
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cf1b612 View commit details
    Browse the repository at this point in the history

  3. mmc: quirks: disable cache on more known-bad Sandisk card date ranges 

    Cards with manufacture dates in 2019 and 2020 have been seen in the wild
that hang indefinitely if issued a cache flush command in CQ mode.

Signed-off-by: Jonathan Bell <[email protected]>
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0232b80 View commit details
    Browse the repository at this point in the history

  4. mmc: block: disable CQ on SD cards when doing non-Discard erase 

    Only CMD38 with Arg=0x1 (Discard) is supported when in CQ mode, so
turn it off before issuing a non-discard erase op.

Signed-off-by: Jonathan Bell <[email protected]>
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8ea0d83 View commit details
    Browse the repository at this point in the history

  5. DTS: bcm2712; re-enable SD slot CQE by default on Pi 5 

    This reverts commit 1b92c93.

Signed-off-by: Jonathan Bell <[email protected]>
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    67f4346 View commit details
    Browse the repository at this point in the history

  6. mmc: quirks: add MMC_QUIRK_BROKEN_ERASE for Phison/Integral cards 

    Recent Integral cards end up with corrupt sectors after a flash erase.
This covers sizes for the A2 range, which can't be differentiated from
the A1 range which might not have the same issue.

Signed-off-by: Jonathan Bell <[email protected]>
    @P33M
    P33M committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d0abbb2 View commit details
    Browse the repository at this point in the history