Input: matrix-keypad - don't map irqs when atomic #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit a96fb71 upstream. There is no need to do conversion from GPIOs to interrupt numbers. Convert row GPIOs to interrupt numbers once in probe() and use this information when the driver needs to enable or disable given interrupt line. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Torokhov <[email protected]>
|
Perhaps not so surprisingly, an almost identical patch is already in kernels from 6.9 onwards. PR updated with a back-port of that commit instead. |
|
@dtor FYI your patch is a fix, not just an optimisation. |
popcornmix
approved these changes
Oct 20, 2024
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 22, 2024
See: raspberrypi/linux#6273 kernel: DRM Writeback connector priority changes See: raspberrypi/linux#6345 kernel: Input: matrix-keypad - don't map irqs when atomic See: raspberrypi/linux#6427
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 22, 2024
See: raspberrypi/linux#6273 kernel: DRM Writeback connector priority changes See: raspberrypi/linux#6345 kernel: Input: matrix-keypad - don't map irqs when atomic See: raspberrypi/linux#6427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling gpio_to_irq can result in irqs being mapped for the first time. which is not safe in atomic context. Enabling CONFIG_PROVE_LOCKING will trigger a kernel splat from _lock_acquire in a call chain from matrix_keypad_scan.
Fix the bug (and improve efficiency) by mapping all GPIO irqs from within the probe function.
Link: https://forums.raspberrypi.com/viewtopic.php?t=378044
Fixes: bab7614 ("Input: add support for generic GPIO-based matrix keypad")