Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR adds IMX477 parameters to use fstrobe #6467

Open
wants to merge 5 commits into
base: rpi-6.6.y
Choose a base branch
from
Open

This PR adds IMX477 parameters to use fstrobe #6467

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
babaf1b
Update imx477.c
khaled98 Nov 14, 2024
8989636
Create kernel-build.yml
khaled98 Nov 14, 2024
34b74c4
Create kernel-build2.yml
khaled98 Nov 14, 2024
e6d3802
Delete .github/workflow directory
khaled98 Nov 14, 2024
20b337f
Delete .github/workflows/kernel-build2.yml
khaled98 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions drivers/media/i2c/imx477.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,22 @@ static int dpc_enable = 1;
module_param(dpc_enable, int, 0644);
MODULE_PARM_DESC(dpc_enable, "Enable on-sensor DPC");

static int fstrobe_enable;
module_param(fstrobe_enable, int, 0644);
MODULE_PARM_DESC(fstrobe_enable, "Enable fstrobe signal");

static int fstrobe_cont_trig;
module_param(fstrobe_cont_trig, int, 0644);
MODULE_PARM_DESC(fstrobe_cont_trig, "Configure fstrobe to be one-shot (0) or continuous (1)");

static int fstrobe_width = 1;
module_param(fstrobe_width, int, 0644);
MODULE_PARM_DESC(fstrobe_width, "Set fstrobe pulse width in units of INCK");

static int fstrobe_delay;
module_param(fstrobe_delay, int, 0644);
MODULE_PARM_DESC(fstrobe_delay, "Set fstrobe delay from end all lines starting to expose and the start of the strobe pulse");

static int trigger_mode;
module_param(trigger_mode, int, 0644);
MODULE_PARM_DESC(trigger_mode, "Set vsync trigger mode: 1=source, 2=sink");
Expand Down Expand Up @@ -1183,6 +1199,9 @@ static int imx477_read_reg(struct imx477 *imx477, u16 reg, u32 len, u32 *val)
{
struct i2c_client *client = v4l2_get_subdevdata(&imx477->sd);
struct i2c_msg msgs[2];
unsigned int fst_width;
unsigned int fst_mult;

u8 addr_buf[2] = { reg >> 8, reg & 0xff };
u8 data_buf[4] = { 0, };
int ret;
Expand Down Expand Up @@ -1741,6 +1760,29 @@ static int imx477_start_streaming(struct imx477 *imx477)
return ret;
}

fst_width = max((unsigned int)fstrobe_width, 1U);
fst_mult = 1;

while (fst_width / fst_mult > 0xffff && fst_mult < 255)
fst_mult++;

fst_width /= fst_mult;

// FLASH_MD_RS
imx477_write_reg(imx477, 0x0c1A, IMX477_REG_VALUE_08BIT,
((fstrobe_cont_trig ? 1 : 0) << 0) | (1 << 1));
// FLASH_STRB_WIDTH
imx477_write_reg(imx477, 0x0c18, IMX477_REG_VALUE_16BIT, fst_width);
// FLASH_STRB_WIDTH adjust
imx477_write_reg(imx477, 0x0c12, IMX477_REG_VALUE_08BIT, fst_mult);
// FLASH_STRB_START_POINT
imx477_write_reg(imx477, 0x0c14, IMX477_REG_VALUE_16BIT, fstrobe_delay);
// FLASH_STRB_DLY_RS
imx477_write_reg(imx477, 0x0c16, IMX477_REG_VALUE_16BIT, 0);
// FLASH_TRIG_RS
imx477_write_reg(imx477, 0x0c1B, IMX477_REG_VALUE_08BIT,
fstrobe_enable ? 1 : 0);

/* Set on-sensor DPC. */
imx477_write_reg(imx477, 0x0b05, IMX477_REG_VALUE_08BIT, !!dpc_enable);
imx477_write_reg(imx477, 0x0b06, IMX477_REG_VALUE_08BIT, !!dpc_enable);
Expand Down