Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-78: [C#] Testing PR update title #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-78: [C#] Testing PR update title #79

wants to merge 2 commits into from

Conversation

raulcd
Copy link
Owner

@raulcd raulcd commented May 29, 2023

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@raulcd raulcd changed the title Test pr GH-78: [C#] Testing PR May 29, 2023
@github-actions
Copy link

⚠️ GitHub issue #78 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

⚠️ GitHub issue #78 has no components, please add labels for components.

@raulcd raulcd changed the title GH-78: [C#] Testing PR GH-78: [C#] Testing PR update title May 29, 2023
@github-actions
Copy link

⚠️ GitHub issue #78 has no components, please add labels for components.

raulcd added a commit to apache/arrow that referenced this pull request May 30, 2023
### Rationale for this change

We are duplicating the Closes issue_id comment on PRs adding it to both the PR body and a comment. There was some discussion to remove it from the comment.

### What changes are included in this PR?

Remove adding extra comment to PR and check whether `Closes XXX` was already added on the body instead of checking comment.

### Are these changes tested?

Yes, I have tested on my fork, see this PR: raulcd#79

### Are there any user-facing changes?

No
* Closes: #14790

Lead-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing closes comment
1 participant