Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Siren chart to use app/templates #60

Open
mabdh opened this issue Jun 16, 2022 · 0 comments · Fixed by #84
Open

Migrate Siren chart to use app/templates #60

mabdh opened this issue Jun 16, 2022 · 0 comments · Fixed by #84
Labels
enhancement New feature or request

Comments

@mabdh
Copy link
Member

mabdh commented Jun 16, 2022

Summary
Siren has its own template. We can reuse app/templates and remove templates in siren.

Proposed solution
Reusing app/templates for siren will make sure that every updates in app/templates can be utilized siren and making a single source of truth for templates. This is also to avoid unnecessary duplication in the charts.
@mabdh mabdh added the enhancement New feature or request label Jun 16, 2022
@mabdh mabdh mentioned this issue Nov 17, 2022
Merged
@mabdh mabdh linked a pull request Nov 17, 2022 that will close this issue
feat(siren): use app chart and upgrade version #84
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(siren): use app chart and upgrade version raystack/charts
1 participant
@mabdh