Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(siren): use app chart and upgrade version #84

Merged
merged 3 commits into from
Nov 16, 2022
Merged

feat(siren): use app chart and upgrade version #84

merged 3 commits into from
Nov 16, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Nov 15, 2022

No description provided.

@mabdh mabdh requested a review from ravisuhag November 15, 2022 12:25
@rohilsurana
Copy link
Member

We don't need to commit the dependency app chart in the git repo, it will be fetched and packed in the CI.

@mabdh
Copy link
Member Author

mabdh commented Nov 16, 2022

We don't need to commit the dependency app chart in the git repo, it will be fetched and packed in the CI.

yes, I mistakenly staged that, removing it

@mabdh mabdh merged commit cbd7841 into main Nov 16, 2022
@mabdh mabdh deleted the bumpup-siren branch November 16, 2022 06:16
@mabdh
Copy link
Member Author

mabdh commented Nov 17, 2022

resolve #60

@mabdh mabdh linked an issue Nov 17, 2022 that may be closed by this pull request
Migrate Siren chart to use app/templates #60
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Siren chart to use app/templates
3 participants
@mabdh @rohilsurana @AkarshSatija