Merge pull request #151 from akinomyoga/fix-test-__bp_install

Fix false-negative test case for __bp_install
rcaloras · Feb 4, 2024 · 1f77dc0 · 1f77dc0
2 parents f872f3f + 99d05b9
commit 1f77dc0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/test/bash-preexec.bats b/test/bash-preexec.bats
@@ -74,13 +74,13 @@ set_exit_code_and_run_precmd() {
 @test "__bp_install should remove trap logic and itself from PROMPT_COMMAND" {
   __bp_install_after_session_init
 
-  [[ "$PROMPT_COMMAND" == *"trap - DEBUG"* ]] || return 1
-  [[ "$PROMPT_COMMAND" == *"__bp_install"* ]] || return 1
+  # Assert that before running, the command contains the install string, and
+  # afterwards it does not
+  [[ "$PROMPT_COMMAND" == *"$__bp_install_string"* ]] || return 1
 
   eval_PROMPT_COMMAND
 
-  [[ "$PROMPT_COMMAND" != *"trap DEBUG"* ]] || return 1
-  [[ "$PROMPT_COMMAND" != *"__bp_install"* ]] || return 1
+  [[ "$PROMPT_COMMAND" != *"$__bp_install_string"* ]] || return 1
 }
 
 @test "__bp_install should preserve an existing DEBUG trap" {