Add the metadata key to RemovedMetadata event id, eg. `RemovedMetadat…

…a.suppressions`
rchache · Aug 22, 2023 · c84a132 · c84a132
1 parent a77dc4e
commit c84a132
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedMetadata.java b/smithy-diff/src/main/java/software/amazon/smithy/diff/evaluators/RemovedMetadata.java
@@ -30,7 +30,7 @@ public final class RemovedMetadata extends AbstractDiffEvaluator {
     public List<ValidationEvent> evaluate(Differences differences) {
         return differences.removedMetadata()
                 .map(metadata -> ValidationEvent.builder()
-                        .id(getEventId())
+                        .id(getEventId() + "." + metadata.getLeft())
                         .severity(Severity.DANGER)
                         .sourceLocation(metadata.getRight().getSourceLocation())
                         .message(String.format(

diff --git a/smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/RemovedMetadataTest.java b/smithy-diff/src/test/java/software/amazon/smithy/diff/evaluators/RemovedMetadataTest.java
@@ -32,6 +32,6 @@ public void detectsRemovedMetadata() {
         Model modelB = Model.assembler().assemble().unwrap();
         List<ValidationEvent> events = ModelDiff.compare(modelA, modelB);
 
-        assertThat(TestHelper.findEvents(events, "RemovedMetadata").size(), equalTo(1));
+        assertThat(TestHelper.findEvents(events, "RemovedMetadata.foo").size(), equalTo(1));
     }
 }