Fix clippy warnings

src/cluster/heartbeat.rs

@@ -103,7 +103,7 @@ async fn do_heartbeat_to_node(
                     );
                 }
 
-                return Err(err.into());
+                return Err(err);
             }
         }
     };
@@ -125,7 +125,7 @@ async fn do_heartbeat_to_node(
             event!(Level::WARN, "Unable to mark node as offline: {}", err);
         }
 
-        Err(err.into())
+        Err(err)
     } else {
         event!(
             Level::TRACE,

src/cmd/mod.rs

@@ -132,13 +132,11 @@ impl Command {
             Command::JoinCluster(cmd) => {
                 let request_id = cmd.request_id();
                 let payload = cmd.execute(db).await;
-                let res = Message::new(
+                Message::new(
                     CMD_CLUSTER_JOIN_CLUSTER,
                     request_id,
                     Self::serialize_response_payload(payload),
-                );
-
-                res
+                )
             }
             Command::ClusterState(cmd) => {
                 let request_id = cmd.request_id();

src/cmd/types.rs

@@ -42,9 +42,9 @@ impl From<String> for SerializedContext {
     }
 }
 
-impl Into<String> for SerializedContext {
-    fn into(self) -> String {
-        self.0
+impl From<SerializedContext> for String {
+    fn from(c: SerializedContext) -> Self {
+        c.0
     }
 }
 
@@ -66,9 +66,9 @@ impl Context {
     }
 }
 
-impl Into<VersionVector> for Context {
-    fn into(self) -> VersionVector {
-        self.version
+impl From<Context> for VersionVector {
+    fn from(c: Context) -> Self {
+        c.version
     }
 }
 

src/persistency/mod.rs

@@ -361,10 +361,10 @@ impl Db {
                 Evaluation::Reached(value) => Ok(value),
                 Evaluation::NotReached => {
                     let failure_iter = quorum_result.failures.iter();
-                    if failure_iter.size_hint().0 > 0 {
-                        if quorum_result.failures.iter().all(|err| err.is_not_found()) {
-                            return Err(Error::NotFound { key: key.clone() });
-                        }
+                    if failure_iter.size_hint().0 > 0
+                        && quorum_result.failures.iter().all(|err| err.is_not_found())
+                    {
+                        return Err(Error::NotFound { key: key.clone() });
                     }
 
                     Err(Error::QuorumNotReached {

src/persistency/storage/mod.rs

@@ -95,7 +95,7 @@ pub(crate) fn version_evaluation(
     lhs: &VersionVector,
     rhs: &VersionVector,
 ) -> Result<VersionEvaluation> {
-    match lhs.causality(&rhs) {
+    match lhs.causality(rhs) {
         VersionVectorOrd::HappenedBefore | VersionVectorOrd::Equals => {
             // the data we are trying to store is actually older than what's already stored.
             // This can happen due to read repair and active anti-entropy processes for instance.