src/client/db_client.rs|57 col 16| warning: redundant pattern matching, consider using is_ok()
--> src/client/db_client.rs:57:16
|
57 | if let Ok(_) = REQUEST_ID.try_with(|request_id| request_id.clone()) {
| -------^^^^^------------------------------------------------------- help: try: if REQUEST_ID.try_with(|request_id| request_id.clone()).is_ok()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: #[warn(clippy::redundant_pattern_matching)] on by default
src/cluster/heartbeat.rs|6 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:6:5
|
6 | //! Every node that joins a running rldb cluster will learn about the other nodes via this protocol
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: #[warn(clippy::doc_lazy_continuation)] on by default
help: indent this line
|
6 | //! Every node that joins a running rldb cluster will learn about the other nodes via this protocol
| +
src/cluster/heartbeat.rs|7 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:7:5
|
7 | //! Nodes exchange they IP/PORT part, which is currently used as key to determine which which partition it owns.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
7 | //! Nodes exchange they IP/PORT part, which is currently used as key to determine which which partition it owns.
| +
src/cluster/heartbeat.rs|8 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:8:5
|
8 | //! With this information, every node can determine the correct owner of any given key.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
8 | //! With this information, every node can determine the correct owner of any given key.
| +
src/cluster/heartbeat.rs|9 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:9:5
|
9 | //! This can also be used to determine which nodes in the ring will contain replicas of the key being added.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
9 | //! This can also be used to determine which nodes in the ring will contain replicas of the key being added.
| +
src/cluster/heartbeat.rs|11 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:11:5
|
11 | //! This happens by each node randomly choosing X nodes to ping every Y seconds (configurable).
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
11 | //! This happens by each node randomly choosing X nodes to ping every Y seconds (configurable).
| +
src/cluster/heartbeat.rs|12 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:12:5
|
12 | //! Hosts that are unreachable or respond with anything other than success are marked as
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
12 | //! Hosts that are unreachable or respond with anything other than success are marked as
| +
src/cluster/heartbeat.rs|13 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:13:5
|
13 | //! [crate::cluster::state::NodeStatus::PossiblyOffline]
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
13 | //! [crate::cluster::state::NodeStatus::PossiblyOffline]
| +
src/cluster/heartbeat.rs|14 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:14:5
|
14 | //! Note: Node are never automatically removed from the cluster. This requires an operator to manually intervene.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
14 | //! Note: Node are never automatically removed from the cluster. This requires an operator to manually intervene.
| +
src/cluster/heartbeat.rs|15 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:15:5
|
15 | //! The reason for that is that reshuffling partitions can be quite expensive (even when using schemes like consistent hashing).
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
15 | //! The reason for that is that reshuffling partitions can be quite expensive (even when using schemes like consistent hashing).
| +
src/cluster/heartbeat.rs|16 col 5| warning: doc list item missing indentation
--> src/cluster/heartbeat.rs:16:5
|
16 | //! So we deliberately chose to let an operator make that decision instead of having automatic detection.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
16 | //! So we deliberately chose to let an operator make that decision instead of having automatic detection.
| +
src/cmd/get.rs|10 col 5| warning: doc list item missing indentation
--> src/cmd/get.rs:10:5
|
10 | //! The server then uses the Context to properly resolve the conflict.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
10 | //! The server then uses the Context to properly resolve the conflict.
| ++++
src/cmd/replication_get.rs|7 col 5| warning: doc list item missing indentation
--> src/cmd/replication_get.rs:7:5
|
7 | //! (as opposed to having to perform a quorum read on multiple nodes)
| ^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
7 | //! (as opposed to having to perform a quorum read on multiple nodes)
| ++
src/cmd/replication_get.rs|9 col 5| warning: doc list item missing indentation
--> src/cmd/replication_get.rs:9:5
|
9 | //! instead of a [crate::cmd::types::Context] object. This is because the coordinator node needs to know
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
9 | //! instead of a [crate::cmd::types::Context] object. This is because the coordinator node needs to know
| +++
src/cmd/replication_get.rs|10 col 5| warning: doc list item missing indentation
--> src/cmd/replication_get.rs:10:5
|
10 | //! all existing versions of a key to be able to handle the request, as opposed to a client that only needs
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
10 | //! all existing versions of a key to be able to handle the request, as opposed to a client that only needs
| +++
src/cmd/replication_get.rs|11 col 5| warning: doc list item missing indentation
--> src/cmd/replication_get.rs:11:5
|
11 | //! the merged version vector instance to be able to resolve conflicts if they exist.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
11 | //! the merged version vector instance to be able to resolve conflicts if they exist.
| +++
src/persistency/partitioning/consistent_hashing.rs|29 col 5| warning: doc list item missing indentation
--> src/persistency/partitioning/consistent_hashing.rs:29:5
|
29 | /// we sometimes refer this array as a 'hash ring'
| ^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
29 | /// we sometimes refer this array as a 'hash ring'
| +
src/persistency/partitioning/consistent_hashing.rs|37 col 5| warning: doc list item missing indentation
--> src/persistency/partitioning/consistent_hashing.rs:37:5
|
37 | /// byte slice that we want to hash to be passed at once (and therefore loaded into memory).
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
37 | /// byte slice that we want to hash to be passed at once (and therefore loaded into memory).
| +
src/persistency/partitioning/consistent_hashing.rs|38 col 5| warning: doc list item missing indentation
--> src/persistency/partitioning/consistent_hashing.rs:38:5
|
38 | /// Usually Hasher APIs include an update and a finalize in order to be able to handle streaming data.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
38 | /// Usually Hasher APIs include an update and a finalize in order to be able to handle streaming data.
| +
src/persistency/partitioning/consistent_hashing.rs|39 col 5| warning: doc list item missing indentation
--> src/persistency/partitioning/consistent_hashing.rs:39:5
|
39 | /// Since we are going to hash fairly small byte slices here (usually an ip/port) pair, this is not a problem.
| ^^^^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
39 | /// Since we are going to hash fairly small byte slices here (usually an ip/port) pair, this is not a problem.
| +