-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LCMCore to provide the LCM interface #14
Conversation
Ok, this seems to be working. It will have to wait until LCMCore is registered, though. |
Current coverage is 100% (diff: 100%)@@ master #14 diff @@
===================================
Files 1 1
Lines 11 8 -3
Methods 0 0
Messages 0 0
Branches 0 0
===================================
- Hits 11 8 -3
Misses 0 0
Partials 0 0
|
no appveyor, huh? |
I'll see if I can get it working: JuliaRobotics/LCMCore.jl#2 |
@tkelman while you're here, can I ask, is the On appveyor,
but actually running the build fails with:
I'm guessing this is because https://github.com/JuliaLang/BinDeps.jl/blob/master/src/dependencies.jl#L616 doesn't include |
It's not in the default list because the vast majority of windows users aren't going to have developer tools (compiler, cmake, etc) installed. It's recommended for usability's sake that you build binaries, upload them to something like github releases, and have your package download them at install time for windows users. You can temporarily |
Ok. I agree that that's the most usable thing for windows, but I don't have the bandwidth to do it. I'll do the defaults modification and restoration. |
Hm, this is harder than anticipated. LCM requires glib, which WinRPM.jl provides, but not in a form that the LCM build will use (presumably because it doesn't supply the headers). I could build glib from source, but it uses autotools and setting that up is a whole other process. It's probably easier to just switch to ZCM instead https://github.com/ZeroCM/zcm which doesn't use |
Are you installing the glib-devel package? Building things for windows is generally complicated and kind of a pain, yeah. You could set up cross-compilation on the opensuse build service and point WinRPM to your personal project, but that's maybe not worth doing if you plan on switching to a different library before putting in the effort to support Windows. |
Ah, I didn't see the glib-dev package. I'll give that a shot. Searching for But yes, agreed on all counts. This probably just isn't worth the effort yet, given that I have roughly two users, one of whom is me and neither of whom is on Windows. I would like to eventually solve this, even if it means moving to ZCM to drop the |
LCMCore.jl can now provide all of the interaction we need with the LCM C API. This means:
handle()
is now magically safe for@async
usage