Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker]: Remove scroll in the format "hh:mm A" when selecting between AM or PM #45691

Closed
mrLuisFer opened this issue Nov 6, 2023 · 2 comments · May be fixed by react-component/picker#692
Closed

[TimePicker]: Remove scroll in the format "hh:mm A" when selecting between AM or PM #45691

mrLuisFer opened this issue Nov 6, 2023 · 2 comments · May be fixed by react-component/picker#692
Assignees
@zombieJ
Labels
🐛 Bug Ant Design Team had proved that this is a bug. Inactive

Comments

@mrLuisFer
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  • Open popUp to select a time
  • Click on PM, (this will move the scroll, making AM hide)

What is expected?

A way, so that the scroll is only done in the hours, but not in AM/PM so that they remain static.

What is actually happening?

Clicking on PM causes AM to hide over it

Environment Info
antd 5.3.0
React 16.8.3
System MacOs Sonoma 14.0
Browser V118.0.5993.70 (arm64)

I was in doubt whether to report it as a Bug or a discussion, but if there is a way to modify the mentioned behavior it would be great, but also to know that this is an expected behavior.
@zombieJ
Copy link
Member

zombieJ commented Nov 7, 2023

open control is not well support since Picker has complex interactive logic. But yes, I think it's a bug.

@zombieJ zombieJ added 🐛 Bug Ant Design Team had proved that this is a bug. and removed unconfirmed labels Nov 7, 2023
@zombieJ zombieJ self-assigned this Nov 7, 2023
@NotEvenANeko NotEvenANeko mentioned this issue Nov 7, 2023
Open
@zombieJ zombieJ mentioned this issue Nov 29, 2023
Merged
69 tasks
@zombieJ
Copy link
Member

zombieJ commented Feb 20, 2024

Picker component has been refactor in 5.14.0, and this issue is discussed and handled with react-component/picker#691 which will be marked as closed.

Please feel free to create new issue if you have any further question :)

Picker 组件于 5.14.0 版本进行了重构，此问题已被 react-component/picker#691 中进行讨论与处理。

如果有任何问题，欢迎随时创建新的 issue :)

@zombieJ zombieJ closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
🐛 Bug Ant Design Team had proved that this is a bug. Inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix scroll on select meridiem NotEvenANeko/picker
2 participants
@zombieJ @mrLuisFer